hanzo2001 commented on a change in pull request #7320:
URL: https://github.com/apache/camel/pull/7320#discussion_r840587524



##########
File path: 
components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitMQDeclareSupport.java
##########
@@ -150,6 +155,18 @@ private void declareAndBindQueue(
         }
     }
 
+    private void passivelyDeclareExchangeAndQueueAndBindThem(
+            final Channel channel, final String queue, final String exchange, 
final String routingKey,
+            final Map<String, Object> bindingArgs)
+
+            throws IOException {
+
+        //if (!endpoint.isPassive()) { log.warn("Forcing passive because 
declaration was skipped"); }

Review comment:
       I didn't know what to do with a situation where the user may have 
defined passive=false but left the skip-declarations enabled.
   I was thinking that logging (warning) this detail would be a good idea but I 
don't know if there is a logging policy (and the class does not even have its 
own logger).
   I was hoping someone could enlighten me. I can clean it up either way




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to