johnpoth commented on code in PR #2835:
URL: https://github.com/apache/camel-k/pull/2835#discussion_r843014095
##########
pkg/apis/camel/v1/maven_types.go:
##########
@@ -30,16 +32,17 @@ type MavenSpec struct {
// A reference to the ConfigMap or Secret key that contains
// the Maven settings.
Settings ValueSource `json:"settings,omitempty"`
- // The Secret name and key, containing the CA certificate(s) used to
connect
+ // The Secrets name and key, containing the CA certificate(s) used to
connect
// to remote Maven repositories.
// It can contain X.509 certificates, and PKCS#7 formatted certificate
chains.
// A JKS formatted keystore is automatically created to store the CA
certificate(s),
// and configured to be used as a trusted certificate(s) by the Maven
commands.
// Note that the root CA certificates are also imported into the
created keystore.
- CASecret *corev1.SecretKeySelector `json:"caSecret,omitempty"`
+ CASecret []corev1.SecretKeySelector `json:"caSecret,omitempty"`
// The Maven build extensions.
// See https://maven.apache.org/guides/mini/guide-using-extensions.html.
Extension []MavenArtifact `json:"extension,omitempty"`
+ Servers []Server `json:"servers,omitempty"`
Review Comment:
I guess if we were to remove the Servers from the 'API', we would have to
perform that
[logic](https://github.com/apache/camel-k/blob/36ec1d005ebb91d2783a8fc6c47cfe117f369b20/pkg/trait/registry.go#L104)
in the builder (if we want to keep it). We would add maybe an extra field in
the builder API to turn on/off this additional logic that would be set in the
registry trait. WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
