johnpoth commented on code in PR #3171:
URL: https://github.com/apache/camel-k/pull/3171#discussion_r843725993
##########
pkg/builder/project.go:
##########
@@ -91,6 +94,16 @@ func generateJavaKeystore(ctx *builderContext) error {
return jvm.GenerateKeystore(ctx.C, ctx.Path, ctx.Maven.TrustStoreName,
ctx.Maven.TrustStorePass, certsData)
}
+func mergeSecrets(secrets []corev1.SecretKeySelector, secret
*corev1.SecretKeySelector) []corev1.SecretKeySelector {
+ if secrets == nil && secret == nil {
Review Comment:
Hi @tadayosi ! Thanks for reviewing!
I didn't know a slice cannot be nil in Go ?
https://go.dev/tour/moretypes/12#:~:text=The%20zero%20value%20of%20a,and%20has%20no%20underlying%20array.
I just wrote it to be bullet proof but I am happy to remove it if you think
it's unnecessary ?
Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
