Author: bvahdat
Date: Sun Jan 20 15:04:49 2013
New Revision: 1435861

URL: http://svn.apache.org/viewvc?rev=1435861&view=rev
Log:
CAMEL-5983: Avoid the negative-tests to behave as false-positive.

Modified:
    
camel/trunk/camel-core/src/test/java/org/apache/camel/component/bean/BeanInvokeStaticTest.java
    
camel/trunk/camel-core/src/test/java/org/apache/camel/component/file/FileProducerTempFileExistsIssueTest.java
    
camel/trunk/camel-core/src/test/java/org/apache/camel/impl/DefaultCamelContextTest.java
    
camel/trunk/camel-core/src/test/java/org/apache/camel/issues/RomeksExceptionTest.java
    
camel/trunk/camel-core/src/test/java/org/apache/camel/language/BeanLanguageInvalidOGNLTest.java
    
camel/trunk/camel-core/src/test/java/org/apache/camel/language/simple/SimpleTest.java
    
camel/trunk/camel-core/src/test/java/org/apache/camel/model/StartingRoutesErrorReportedTest.java
    
camel/trunk/camel-core/src/test/java/org/apache/camel/processor/DefaultErrorHandlerRedeliveryTest.java
    
camel/trunk/camel-core/src/test/java/org/apache/camel/processor/WeightedRandomLoadBalanceTest.java
    
camel/trunk/camel-core/src/test/java/org/apache/camel/processor/WeightedRoundRobinLoadBalanceTest.java
    
camel/trunk/camel-core/src/test/java/org/apache/camel/processor/async/AsyncRouteWithErrorTest.java
    
camel/trunk/components/camel-apns/src/test/java/org/apache/camel/component/apns/util/AssertUtilsTest.java
    
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsIpEndpointSpringTest.java
    
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsIpEndpointTest.java
    
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsIpHeaderTransferTest.java
    
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsLookupEndpointSpringTest.java
    
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsLookupEndpointTest.java
    
camel/trunk/components/camel-ibatis/src/test/java/org/apache/camel/component/ibatis/IBatisUnknownStatementTypeTest.java
    
camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/HttpAuthMethodPriorityTest.java
    
camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/HttpBasicAuthTest.java
    
camel/trunk/components/camel-jt400/src/test/java/org/apache/camel/component/jt400/Jt400ComponentDefaultConnectionPoolTest.java
    
camel/trunk/components/camel-mail/src/test/java/org/apache/camel/component/mail/security/SslContextParametersMailRouteTest.java
    
camel/trunk/components/camel-mybatis/src/test/java/org/apache/camel/component/mybatis/MyBatisUnknownStatementTypeTest.java
    
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/EndpointReferenceTest.java
    
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/config/ErrorHandlerRouteContextRefNotFoundTest.java
    
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/config/SpringRouteNoFromTest.java
    
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/config/SpringRouteNoOutputTest.java
    
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/MixedTransactionPropagationTest.java
    
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/SpringTransactionalClientDataSourceTransactedTest.java
    
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceMinimalConfigurationTest.java
    
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceNotTransactedTest.java
    
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceTest.java
    
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceWithOnExceptionRollbackTest.java
    
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceWithOnExceptionTest.java
    
camel/trunk/tests/camel-itest/src/test/java/org/apache/camel/itest/sql/FromJmsToJdbcIdempotentConsumerToJmsXaTest.java

Modified: 
camel/trunk/camel-core/src/test/java/org/apache/camel/component/bean/BeanInvokeStaticTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/camel-core/src/test/java/org/apache/camel/component/bean/BeanInvokeStaticTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/camel-core/src/test/java/org/apache/camel/component/bean/BeanInvokeStaticTest.java
 (original)
+++ 
camel/trunk/camel-core/src/test/java/org/apache/camel/component/bean/BeanInvokeStaticTest.java
 Sun Jan 20 15:04:49 2013
@@ -53,6 +53,7 @@ public class BeanInvokeStaticTest extend
         });
         try {
             context.start();
+            fail("Should have thrown exception");
         } catch (FailedToCreateRouteException e) {
             assertIsInstanceOf(RuntimeCamelException.class, e.getCause());
             assertIsInstanceOf(MethodNotFoundException.class, 
e.getCause().getCause());

Modified: 
camel/trunk/camel-core/src/test/java/org/apache/camel/component/file/FileProducerTempFileExistsIssueTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/camel-core/src/test/java/org/apache/camel/component/file/FileProducerTempFileExistsIssueTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/camel-core/src/test/java/org/apache/camel/component/file/FileProducerTempFileExistsIssueTest.java
 (original)
+++ 
camel/trunk/camel-core/src/test/java/org/apache/camel/component/file/FileProducerTempFileExistsIssueTest.java
 Sun Jan 20 15:04:49 2013
@@ -41,6 +41,7 @@ public class FileProducerTempFileExistsI
     public void testIllegalConfiguration() throws Exception {
         try {
             
context.getEndpoint("file://target/tempprefix?fileExist=Append&tempPrefix=foo").createProducer();
+            fail("Should have thrown exception");
         } catch (IllegalArgumentException e) {
             assertEquals("You cannot set both fileExist=Append and tempPrefix 
options", e.getMessage());
         }

Modified: 
camel/trunk/camel-core/src/test/java/org/apache/camel/impl/DefaultCamelContextTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/camel-core/src/test/java/org/apache/camel/impl/DefaultCamelContextTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/camel-core/src/test/java/org/apache/camel/impl/DefaultCamelContextTest.java
 (original)
+++ 
camel/trunk/camel-core/src/test/java/org/apache/camel/impl/DefaultCamelContextTest.java
 Sun Jan 20 15:04:49 2013
@@ -223,6 +223,7 @@ public class DefaultCamelContextTest ext
         try {
             Endpoint endpoint = ctx.hasEndpoint(null);
             assertNull("Should not have endpoint", endpoint);
+            fail("Should have thrown exception");
         } catch (ResolveEndpointFailedException e) {
             // expected
         }

Modified: 
camel/trunk/camel-core/src/test/java/org/apache/camel/issues/RomeksExceptionTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/camel-core/src/test/java/org/apache/camel/issues/RomeksExceptionTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/camel-core/src/test/java/org/apache/camel/issues/RomeksExceptionTest.java
 (original)
+++ 
camel/trunk/camel-core/src/test/java/org/apache/camel/issues/RomeksExceptionTest.java
 Sun Jan 20 15:04:49 2013
@@ -50,6 +50,7 @@ public class RomeksExceptionTest extends
 
         try {
             template.sendBodyAndHeader("direct:start", "<body/>", "route", 
route);
+            fail("Should have thrown exception");
         } catch (RuntimeCamelException e) {
             assertTrue(e.getCause() instanceof IllegalArgumentException);
             assertEquals("Exception thrown intentionally.", 
e.getCause().getMessage());

Modified: 
camel/trunk/camel-core/src/test/java/org/apache/camel/language/BeanLanguageInvalidOGNLTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/camel-core/src/test/java/org/apache/camel/language/BeanLanguageInvalidOGNLTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/camel-core/src/test/java/org/apache/camel/language/BeanLanguageInvalidOGNLTest.java
 (original)
+++ 
camel/trunk/camel-core/src/test/java/org/apache/camel/language/BeanLanguageInvalidOGNLTest.java
 Sun Jan 20 15:04:49 2013
@@ -41,6 +41,7 @@ public class BeanLanguageInvalidOGNLTest
         });
         try {
             context.start();
+            fail("Should have thrown exception");
         } catch (FailedToCreateRouteException e) {
             RuntimeCamelException rce = 
assertIsInstanceOf(RuntimeCamelException.class, e.getCause());
             MethodNotFoundException mnfe = 
assertIsInstanceOf(MethodNotFoundException.class, rce.getCause());

Modified: 
camel/trunk/camel-core/src/test/java/org/apache/camel/language/simple/SimpleTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/camel-core/src/test/java/org/apache/camel/language/simple/SimpleTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/camel-core/src/test/java/org/apache/camel/language/simple/SimpleTest.java
 (original)
+++ 
camel/trunk/camel-core/src/test/java/org/apache/camel/language/simple/SimpleTest.java
 Sun Jan 20 15:04:49 2013
@@ -422,6 +422,7 @@ public class SimpleTest extends Language
         exchange.getIn().setBody(null);
         try {
             assertExpression("${mandatoryBodyAs('String')}", "");
+            fail("Should have thrown exception");
         } catch (CamelExecutionException e) {
             assertIsInstanceOf(InvalidPayloadException.class, e.getCause());
         }

Modified: 
camel/trunk/camel-core/src/test/java/org/apache/camel/model/StartingRoutesErrorReportedTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/camel-core/src/test/java/org/apache/camel/model/StartingRoutesErrorReportedTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/camel-core/src/test/java/org/apache/camel/model/StartingRoutesErrorReportedTest.java
 (original)
+++ 
camel/trunk/camel-core/src/test/java/org/apache/camel/model/StartingRoutesErrorReportedTest.java
 Sun Jan 20 15:04:49 2013
@@ -67,6 +67,7 @@ public class StartingRoutesErrorReported
                 }
             });
             context.start();
+            fail("Should have thrown exception");
         } catch (FailedToCreateRouteException e) {
             assertTrue(e.getMessage().startsWith("Failed to create route 
route3 at: >>> Bean[ref:] <<< in route:"
                     + " Route[[From[direct:start]] -> [To[mock:foo], 
Bean[ref:]]] because of"));
@@ -84,6 +85,7 @@ public class StartingRoutesErrorReported
                 }
             });
             context.start();
+            fail("Should have thrown exception");
         } catch (FailedToCreateRouteException e) {
             assertTrue(e.getMessage().contains("Ensure that the data format is 
valid and the associated Camel component is present on the classpath"));
         }

Modified: 
camel/trunk/camel-core/src/test/java/org/apache/camel/processor/DefaultErrorHandlerRedeliveryTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/camel-core/src/test/java/org/apache/camel/processor/DefaultErrorHandlerRedeliveryTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/camel-core/src/test/java/org/apache/camel/processor/DefaultErrorHandlerRedeliveryTest.java
 (original)
+++ 
camel/trunk/camel-core/src/test/java/org/apache/camel/processor/DefaultErrorHandlerRedeliveryTest.java
 Sun Jan 20 15:04:49 2013
@@ -34,6 +34,7 @@ public class DefaultErrorHandlerRedelive
 
         try {
             template.sendBody("direct:start", "Hello World");
+            fail("Should have thrown exception");
         } catch (RuntimeCamelException e) {
             // expected
         }
@@ -46,6 +47,7 @@ public class DefaultErrorHandlerRedelive
 
         try {
             template.sendBody("direct:no", "Hello World");
+            fail("Should have thrown exception");
         } catch (RuntimeCamelException e) {
             // expected
         }
@@ -57,6 +59,7 @@ public class DefaultErrorHandlerRedelive
         counter = 0;
         try {
             template.sendBody("direct:one", "Hello World");
+            fail("Should have thrown exception");
         } catch (RuntimeCamelException e) {
             // expected
         }

Modified: 
camel/trunk/camel-core/src/test/java/org/apache/camel/processor/WeightedRandomLoadBalanceTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/camel-core/src/test/java/org/apache/camel/processor/WeightedRandomLoadBalanceTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/camel-core/src/test/java/org/apache/camel/processor/WeightedRandomLoadBalanceTest.java
 (original)
+++ 
camel/trunk/camel-core/src/test/java/org/apache/camel/processor/WeightedRandomLoadBalanceTest.java
 Sun Jan 20 15:04:49 2013
@@ -105,8 +105,6 @@ public class WeightedRandomLoadBalanceTe
     }
     
     public void testUnmatchedRatiosToProcessors() throws Exception {
-        boolean error = false;
-        
         try {
             context.addRoutes(new RouteBuilder() {
                 public void configure() {
@@ -118,12 +116,10 @@ public class WeightedRandomLoadBalanceTe
                 }
             });
             context.start();
+            fail("Should have thrown exception");
         } catch (IllegalArgumentException e) {
             assertEquals("Loadbalacing with 3 should match number of 
distributions 2", e.getMessage());
-            error = true;
         }
-
-        assertTrue(error);
     }
     
     protected void sendBulkMessages(int number) {

Modified: 
camel/trunk/camel-core/src/test/java/org/apache/camel/processor/WeightedRoundRobinLoadBalanceTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/camel-core/src/test/java/org/apache/camel/processor/WeightedRoundRobinLoadBalanceTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/camel-core/src/test/java/org/apache/camel/processor/WeightedRoundRobinLoadBalanceTest.java
 (original)
+++ 
camel/trunk/camel-core/src/test/java/org/apache/camel/processor/WeightedRoundRobinLoadBalanceTest.java
 Sun Jan 20 15:04:49 2013
@@ -111,8 +111,6 @@ public class WeightedRoundRobinLoadBalan
     }
     
     public void testUnmatchedRatiosToProcessors() throws Exception {
-        boolean error = false;
-        
         try {
             context.addRoutes(new RouteBuilder() {
                 public void configure() {
@@ -124,12 +122,10 @@ public class WeightedRoundRobinLoadBalan
                 }
             });
             context.start();
+            fail("Should have thrown exception");
         } catch (IllegalArgumentException e) {
             assertEquals("Loadbalacing with 3 should match number of 
distributions 2", e.getMessage());
-            error = true;
         }
-
-        assertTrue(error);
     }
     
     protected void sendBulkMessages(int number) {

Modified: 
camel/trunk/camel-core/src/test/java/org/apache/camel/processor/async/AsyncRouteWithErrorTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/camel-core/src/test/java/org/apache/camel/processor/async/AsyncRouteWithErrorTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/camel-core/src/test/java/org/apache/camel/processor/async/AsyncRouteWithErrorTest.java
 (original)
+++ 
camel/trunk/camel-core/src/test/java/org/apache/camel/processor/async/AsyncRouteWithErrorTest.java
 Sun Jan 20 15:04:49 2013
@@ -42,6 +42,7 @@ public class AsyncRouteWithErrorTest ext
         // send a request reply to the direct start endpoint
         try {
             template.requestBody("direct:start", "Hello");
+            fail("Should have thrown exception");
         } catch (CamelExecutionException e) {
             // expected an execution exception
             assertEquals("Damn forced by unit test", 
e.getCause().getMessage());

Modified: 
camel/trunk/components/camel-apns/src/test/java/org/apache/camel/component/apns/util/AssertUtilsTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-apns/src/test/java/org/apache/camel/component/apns/util/AssertUtilsTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-apns/src/test/java/org/apache/camel/component/apns/util/AssertUtilsTest.java
 (original)
+++ 
camel/trunk/components/camel-apns/src/test/java/org/apache/camel/component/apns/util/AssertUtilsTest.java
 Sun Jan 20 15:04:49 2013
@@ -30,6 +30,7 @@ public class AssertUtilsTest {
     public void testAssertIsTrueInvalid() {
         try {
             AssertUtils.isTrue(false, "message");
+            Assert.fail("Should have thrown exception");
         } catch (IllegalArgumentException e) {
             Assert.assertEquals("[Assert is true] message", e.getMessage());
         }
@@ -44,6 +45,7 @@ public class AssertUtilsTest {
     public void testAssertNotNullInvalid() {
         try {
             AssertUtils.notNull(null, "message");
+            Assert.fail("Should have thrown exception");
         } catch (IllegalArgumentException e) {
             Assert.assertEquals("[Assert not null] message", e.getMessage());
         }

Modified: 
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsIpEndpointSpringTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsIpEndpointSpringTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsIpEndpointSpringTest.java
 (original)
+++ 
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsIpEndpointSpringTest.java
 Sun Jan 20 15:04:49 2013
@@ -42,6 +42,7 @@ public class DnsIpEndpointSpringTest ext
         resultEndpoint.expectedMessageCount(0);
         try {
             template.sendBodyAndHeader("hello", "dns.domain", null);
+            fail("Should have thrown exception");
         } catch (Throwable t) {
             assertTrue(t.getCause() instanceof IllegalArgumentException);
         }
@@ -53,6 +54,7 @@ public class DnsIpEndpointSpringTest ext
         resultEndpoint.expectedMessageCount(0);
         try {
             template.sendBodyAndHeader("hello", "dns.domain", "");
+            fail("Should have thrown exception");
         } catch (Throwable t) {
             assertTrue(t.getCause() instanceof IllegalArgumentException);
         }

Modified: 
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsIpEndpointTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsIpEndpointTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsIpEndpointTest.java
 (original)
+++ 
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsIpEndpointTest.java
 Sun Jan 20 15:04:49 2013
@@ -49,6 +49,7 @@ public class DnsIpEndpointTest extends C
         resultEndpoint.expectedMessageCount(0);
         try {
             template.sendBodyAndHeader("hello", "dns.domain", null);
+            fail("Should have thrown exception");
         } catch (Throwable t) {
             assertTrue(t.getCause() instanceof IllegalArgumentException);
         }
@@ -60,6 +61,7 @@ public class DnsIpEndpointTest extends C
         resultEndpoint.expectedMessageCount(0);
         try {
             template.sendBodyAndHeader("hello", "dns.domain", "");
+            fail("Should have thrown exception");
         } catch (Throwable t) {
             assertTrue(t.getCause() instanceof IllegalArgumentException);
         }

Modified: 
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsIpHeaderTransferTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsIpHeaderTransferTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsIpHeaderTransferTest.java
 (original)
+++ 
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsIpHeaderTransferTest.java
 Sun Jan 20 15:04:49 2013
@@ -50,6 +50,7 @@ public class DnsIpHeaderTransferTest ext
 
         try {
             template.sendBodyAndHeader("hello", "dns.domain", null);
+            fail("Should have thrown exception");
         } catch (Throwable t) {
             assertTrue(t.getCause() instanceof IllegalArgumentException);
         }
@@ -62,6 +63,7 @@ public class DnsIpHeaderTransferTest ext
 
         try {
             template.sendBodyAndHeader("hello", "dns.domain", "");
+            fail("Should have thrown exception");
         } catch (Throwable t) {
             assertTrue(t.getCause() instanceof IllegalArgumentException);
         }

Modified: 
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsLookupEndpointSpringTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsLookupEndpointSpringTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsLookupEndpointSpringTest.java
 (original)
+++ 
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsLookupEndpointSpringTest.java
 Sun Jan 20 15:04:49 2013
@@ -48,6 +48,7 @@ public class DnsLookupEndpointSpringTest
         resultEndpoint.expectedMessageCount(0);
         try {
             template.sendBody("hello");
+            fail("Should have thrown exception");
         } catch (Throwable t) {
             assertTrue(t.getCause() instanceof IllegalArgumentException);
         }
@@ -59,8 +60,8 @@ public class DnsLookupEndpointSpringTest
         resultEndpoint.expectedMessageCount(0);
         try {
             template.sendBodyAndHeader("hello", "dns.name", "");
+            fail("Should have thrown exception");
         } catch (Throwable t) {
-
             assertTrue(t.toString(), t.getCause() instanceof 
IllegalArgumentException);
         }
         resultEndpoint.assertIsSatisfied();

Modified: 
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsLookupEndpointTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsLookupEndpointTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsLookupEndpointTest.java
 (original)
+++ 
camel/trunk/components/camel-dns/src/test/java/org/apache/camel/component/dns/DnsLookupEndpointTest.java
 Sun Jan 20 15:04:49 2013
@@ -55,6 +55,7 @@ public class DnsLookupEndpointTest exten
         resultEndpoint.expectedMessageCount(0);
         try {
             template.sendBody("hello");
+            fail("Should have thrown exception");
         } catch (Throwable t) {
             assertTrue(t.getCause() instanceof IllegalArgumentException);
         }
@@ -66,8 +67,8 @@ public class DnsLookupEndpointTest exten
         resultEndpoint.expectedMessageCount(0);
         try {
             template.sendBodyAndHeader("hello", "dns.name", "");
+            fail("Should have thrown exception");
         } catch (Throwable t) {
-
             assertTrue(t.toString(), t.getCause() instanceof 
IllegalArgumentException);
         }
         resultEndpoint.assertIsSatisfied();

Modified: 
camel/trunk/components/camel-ibatis/src/test/java/org/apache/camel/component/ibatis/IBatisUnknownStatementTypeTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-ibatis/src/test/java/org/apache/camel/component/ibatis/IBatisUnknownStatementTypeTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-ibatis/src/test/java/org/apache/camel/component/ibatis/IBatisUnknownStatementTypeTest.java
 (original)
+++ 
camel/trunk/components/camel-ibatis/src/test/java/org/apache/camel/component/ibatis/IBatisUnknownStatementTypeTest.java
 Sun Jan 20 15:04:49 2013
@@ -38,6 +38,7 @@ public class IBatisUnknownStatementTypeT
         });
         try {
             context.start();
+            fail("Should have thrown exception");
         } catch (FailedToCreateProducerException e) {
             assertIsInstanceOf(IllegalArgumentException.class, e.getCause());
             assertEquals("statementType must be specified on: 
Endpoint[ibatis://selectAllAccounts]", e.getCause().getMessage());

Modified: 
camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/HttpAuthMethodPriorityTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/HttpAuthMethodPriorityTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/HttpAuthMethodPriorityTest.java
 (original)
+++ 
camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/HttpAuthMethodPriorityTest.java
 Sun Jan 20 15:04:49 2013
@@ -96,6 +96,7 @@ public class HttpAuthMethodPriorityTest 
     public void testAuthMethodPriorityNTLM() throws Exception {
         try {
             
template.requestBody("http://localhost:{{port}}/test?authMethod=Basic&authMethodPriority=NTLM&authUsername=donald&authPassword=duck";,
 "Hello World", String.class);
+            fail("Should have thrown exception");
         } catch (RuntimeCamelException e) {
             HttpOperationFailedException cause = 
assertIsInstanceOf(HttpOperationFailedException.class, e.getCause());
             assertEquals(401, cause.getStatusCode());

Modified: 
camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/HttpBasicAuthTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/HttpBasicAuthTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/HttpBasicAuthTest.java
 (original)
+++ 
camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/HttpBasicAuthTest.java
 Sun Jan 20 15:04:49 2013
@@ -77,6 +77,7 @@ public class HttpBasicAuthTest extends B
     public void testHttpBasicAuthInvalidPassword() throws Exception {
         try {
             
template.requestBody("http://localhost:{{port}}/test?authMethod=Basic&authUsername=donald&authPassword=sorry";,
 "Hello World", String.class);
+            fail("Should have thrown exception");
         } catch (RuntimeCamelException e) {
             HttpOperationFailedException cause = 
assertIsInstanceOf(HttpOperationFailedException.class, e.getCause());
             assertEquals(401, cause.getStatusCode());

Modified: 
camel/trunk/components/camel-jt400/src/test/java/org/apache/camel/component/jt400/Jt400ComponentDefaultConnectionPoolTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-jt400/src/test/java/org/apache/camel/component/jt400/Jt400ComponentDefaultConnectionPoolTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-jt400/src/test/java/org/apache/camel/component/jt400/Jt400ComponentDefaultConnectionPoolTest.java
 (original)
+++ 
camel/trunk/components/camel-jt400/src/test/java/org/apache/camel/component/jt400/Jt400ComponentDefaultConnectionPoolTest.java
 Sun Jan 20 15:04:49 2013
@@ -21,6 +21,7 @@ import java.util.HashMap;
 import com.ibm.as400.access.AS400ConnectionPool;
 import org.apache.camel.CamelException;
 import org.junit.After;
+import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
 
@@ -39,6 +40,7 @@ public class Jt400ComponentDefaultConnec
             
component.createEndpoint("jt400://user:password@host/qsys.lib/library.lib/program.xxx",
                     "/user:password@host/qsys.lib/library.lib/program.xxx",
                     new HashMap<String, Object>(0));
+            Assert.fail("Should have thrown exception");
         } catch (CamelException e) {
             /* Expected */
         }

Modified: 
camel/trunk/components/camel-mail/src/test/java/org/apache/camel/component/mail/security/SslContextParametersMailRouteTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-mail/src/test/java/org/apache/camel/component/mail/security/SslContextParametersMailRouteTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-mail/src/test/java/org/apache/camel/component/mail/security/SslContextParametersMailRouteTest.java
 (original)
+++ 
camel/trunk/components/camel-mail/src/test/java/org/apache/camel/component/mail/security/SslContextParametersMailRouteTest.java
 Sun Jan 20 15:04:49 2013
@@ -102,6 +102,7 @@ public class SslContextParametersMailRou
         
         try {
             template.sendBodyAndHeaders("direct:in", "Test Email Body", 
headers);
+            fail("Should have thrown exception");
         } catch (CamelExecutionException e) {
             assertTrue(e.getCause().getCause() instanceof 
SSLHandshakeException);
             assertTrue(e.getCause().getCause().getMessage().contains(

Modified: 
camel/trunk/components/camel-mybatis/src/test/java/org/apache/camel/component/mybatis/MyBatisUnknownStatementTypeTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-mybatis/src/test/java/org/apache/camel/component/mybatis/MyBatisUnknownStatementTypeTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-mybatis/src/test/java/org/apache/camel/component/mybatis/MyBatisUnknownStatementTypeTest.java
 (original)
+++ 
camel/trunk/components/camel-mybatis/src/test/java/org/apache/camel/component/mybatis/MyBatisUnknownStatementTypeTest.java
 Sun Jan 20 15:04:49 2013
@@ -38,6 +38,7 @@ public class MyBatisUnknownStatementType
         });
         try {
             context.start();
+            fail("Should have thrown exception");
         } catch (FailedToCreateProducerException e) {
             assertIsInstanceOf(IllegalArgumentException.class, e.getCause());
             assertEquals("statementType must be specified on: 
Endpoint[mybatis://selectAllAccounts]", e.getCause().getMessage());

Modified: 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/EndpointReferenceTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/EndpointReferenceTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/EndpointReferenceTest.java
 (original)
+++ 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/EndpointReferenceTest.java
 Sun Jan 20 15:04:49 2013
@@ -74,6 +74,7 @@ public class EndpointReferenceTest exten
         RouteContext routeContext = new DefaultRouteContext(context);
         try {
             routeContext.resolveEndpoint(null, "endpoint1");
+            fail("Should have thrown exception");
         } catch (NoSuchEndpointException exception) {
             assertTrue("Get a wrong exception message", 
exception.getMessage().contains("make sure the endpoint has the same camel 
context as the route does"));
         }

Modified: 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/config/ErrorHandlerRouteContextRefNotFoundTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/config/ErrorHandlerRouteContextRefNotFoundTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/config/ErrorHandlerRouteContextRefNotFoundTest.java
 (original)
+++ 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/config/ErrorHandlerRouteContextRefNotFoundTest.java
 Sun Jan 20 15:04:49 2013
@@ -32,6 +32,7 @@ public class ErrorHandlerRouteContextRef
     protected void setUp() throws Exception {
         try {
             super.setUp();
+            fail("Should have thrown exception");
         } catch (RuntimeCamelException e) {
             FailedToCreateRouteException cause = 
assertIsInstanceOf(FailedToCreateRouteException.class, e.getCause());
             NoSuchBeanException nsbe = 
assertIsInstanceOf(NoSuchBeanException.class, cause.getCause());

Modified: 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/config/SpringRouteNoFromTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/config/SpringRouteNoFromTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/config/SpringRouteNoFromTest.java
 (original)
+++ 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/config/SpringRouteNoFromTest.java
 Sun Jan 20 15:04:49 2013
@@ -36,12 +36,16 @@ public class SpringRouteNoFromTest exten
 
     @Override
     protected AbstractXmlApplicationContext createApplicationContext() {
+        AbstractXmlApplicationContext answer;
         try {
-            return new 
ClassPathXmlApplicationContext("org/apache/camel/spring/config/SpringRouteNoFromTest.xml");
+            answer = new 
ClassPathXmlApplicationContext("org/apache/camel/spring/config/SpringRouteNoFromTest.xml");
+            fail("Should have thrown exception");
         } catch (Exception e) {
             IllegalArgumentException iae = (IllegalArgumentException) 
e.getCause().getCause();
             assertEquals("Route myRoute has no inputs: Route[[] -> 
[To[mock:result]]]", iae.getMessage());
             return null;
         }
+
+        return answer;
     }
 }

Modified: 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/config/SpringRouteNoOutputTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/config/SpringRouteNoOutputTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/config/SpringRouteNoOutputTest.java
 (original)
+++ 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/config/SpringRouteNoOutputTest.java
 Sun Jan 20 15:04:49 2013
@@ -36,12 +36,16 @@ public class SpringRouteNoOutputTest ext
 
     @Override
     protected AbstractXmlApplicationContext createApplicationContext() {
+        AbstractXmlApplicationContext answer;
         try {
-            return new 
ClassPathXmlApplicationContext("org/apache/camel/spring/config/SpringRouteNoOutputTest.xml");
+            answer = new 
ClassPathXmlApplicationContext("org/apache/camel/spring/config/SpringRouteNoOutputTest.xml");
+            fail("Should have thrown exception");
         } catch (Exception e) {
             IllegalArgumentException iae = (IllegalArgumentException) 
e.getCause().getCause();
             assertEquals("Route myRoute has no outputs: 
Route[[From[direct:start]] -> []]", iae.getMessage());
             return null;
         }
+
+        return answer;
     }
 }

Modified: 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/MixedTransactionPropagationTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/MixedTransactionPropagationTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/MixedTransactionPropagationTest.java
 (original)
+++ 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/MixedTransactionPropagationTest.java
 Sun Jan 20 15:04:49 2013
@@ -57,6 +57,7 @@ public class MixedTransactionPropagation
     public void testFail() throws Exception {
         try {
             template.sendBody("direct:fail", "Hello World");
+            fail("Should have thrown exception");
         } catch (RuntimeCamelException e) {
             // expected as we fail
             assertIsInstanceOf(RuntimeCamelException.class, e.getCause());

Modified: 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/SpringTransactionalClientDataSourceTransactedTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/SpringTransactionalClientDataSourceTransactedTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/SpringTransactionalClientDataSourceTransactedTest.java
 (original)
+++ 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/SpringTransactionalClientDataSourceTransactedTest.java
 Sun Jan 20 15:04:49 2013
@@ -55,6 +55,7 @@ public class SpringTransactionalClientDa
     public void testTransactionRollback() throws Exception {
         try {
             template.sendBody("direct:fail", "Hello World");
+            fail("Should have thrown exception");
         } catch (RuntimeCamelException e) {
             // expected as we fail
             assertIsInstanceOf(RuntimeCamelException.class, e.getCause());

Modified: 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceMinimalConfigurationTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceMinimalConfigurationTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceMinimalConfigurationTest.java
 (original)
+++ 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceMinimalConfigurationTest.java
 Sun Jan 20 15:04:49 2013
@@ -55,6 +55,7 @@ public class TransactionalClientDataSour
     public void testTransactionRollback() throws Exception {
         try {
             template.sendBody("direct:fail", "Hello World");
+            fail("Should have thrown exception");
         } catch (RuntimeCamelException e) {
             // expected as we fail
             assertIsInstanceOf(RuntimeCamelException.class, e.getCause());

Modified: 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceNotTransactedTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceNotTransactedTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceNotTransactedTest.java
 (original)
+++ 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceNotTransactedTest.java
 Sun Jan 20 15:04:49 2013
@@ -28,6 +28,7 @@ public class TransactionalClientDataSour
     public void testTransactionRollback() throws Exception {
         try {
             template.sendBody("direct:fail", "Hello World");
+            fail("Should have thrown exception");
         } catch (RuntimeCamelException e) {
             // expected as we fail
             assertTrue(e.getCause() instanceof IllegalArgumentException);

Modified: 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceTest.java
 (original)
+++ 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceTest.java
 Sun Jan 20 15:04:49 2013
@@ -39,6 +39,7 @@ public class TransactionalClientDataSour
     public void testTransactionRollback() throws Exception {
         try {
             template.sendBody("direct:fail", "Hello World");
+            fail("Should have thrown exception");
         } catch (RuntimeCamelException e) {
             // expected as we fail
             assertIsInstanceOf(RuntimeCamelException.class, e.getCause());

Modified: 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceWithOnExceptionRollbackTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceWithOnExceptionRollbackTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceWithOnExceptionRollbackTest.java
 (original)
+++ 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceWithOnExceptionRollbackTest.java
 Sun Jan 20 15:04:49 2013
@@ -34,6 +34,7 @@ public class TransactionalClientDataSour
 
         try {
             template.sendBody("direct:fail", "Hello World");
+            fail("Should have thrown exception");
         } catch (RuntimeCamelException e) {
             // expected as we fail
             assertIsInstanceOf(RuntimeCamelException.class, e.getCause());

Modified: 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceWithOnExceptionTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceWithOnExceptionTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceWithOnExceptionTest.java
 (original)
+++ 
camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/interceptor/TransactionalClientDataSourceWithOnExceptionTest.java
 Sun Jan 20 15:04:49 2013
@@ -33,6 +33,7 @@ public class TransactionalClientDataSour
 
         try {
             template.sendBody("direct:fail", "Hello World");
+            fail("Should have thrown exception");
         } catch (RuntimeCamelException e) {
             // expected as we fail
             assertIsInstanceOf(RuntimeCamelException.class, e.getCause());

Modified: 
camel/trunk/tests/camel-itest/src/test/java/org/apache/camel/itest/sql/FromJmsToJdbcIdempotentConsumerToJmsXaTest.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/tests/camel-itest/src/test/java/org/apache/camel/itest/sql/FromJmsToJdbcIdempotentConsumerToJmsXaTest.java?rev=1435861&r1=1435860&r2=1435861&view=diff
==============================================================================
--- 
camel/trunk/tests/camel-itest/src/test/java/org/apache/camel/itest/sql/FromJmsToJdbcIdempotentConsumerToJmsXaTest.java
 (original)
+++ 
camel/trunk/tests/camel-itest/src/test/java/org/apache/camel/itest/sql/FromJmsToJdbcIdempotentConsumerToJmsXaTest.java
 Sun Jan 20 15:04:49 2013
@@ -46,6 +46,7 @@ public class FromJmsToJdbcIdempotentCons
         // shutdown the embedded Derby database so that the next test becomes 
a clean initial state 
         try {
             
DriverManager.getConnection("jdbc:derby:target/testdb;shutdown=true");
+            fail("Should have thrown exception");
         } catch (SQLException e) {
             // a successful shutdown always results in an SQLException to 
indicate that Derby has shut down and that there is no other exception.
             assertEquals("Database 'target/testdb' shutdown.", e.getMessage());


Reply via email to