tadayosi commented on code in PR #3245:
URL: https://github.com/apache/camel-k/pull/3245#discussion_r861616889
##########
pkg/cmd/install.go:
##########
@@ -142,6 +142,7 @@ func newCmdInstall(rootCmdOptions *RootCmdOptions)
(*cobra.Command, *installCmdO
cmd.Flags().StringArray("node-selector", nil, "Add a NodeSelector to
the operator Pod")
cmd.Flags().StringArray("operator-resources", nil, "Define the
resources requests and limits assigned to the operator Pod as
<requestType.requestResource=value> (i.e., limits.memory=256Mi)")
cmd.Flags().StringArray("operator-env-vars", nil, "Add an environment
variable to set in the operator Pod(s), as <name=value>")
+ cmd.Flags().StringP("log-level", "v", "info", "The level of operator
logging (default - info): info or 0, debug or 1")
Review Comment:
In `kamel run`, `-v` is already used for volume. For consistency throughout
cli isn't it good idea to avoid overloading of short flags and use a different
one? For example, what about using `-V` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]