zhfeng commented on code in PR #3777:
URL: https://github.com/apache/camel-quarkus/pull/3777#discussion_r866678095
##########
integration-test-groups/aws2/aws2-s3/src/test/java/org/apache/camel/quarkus/component/aws2/s3/it/Aws2S3Test.java:
##########
@@ -304,23 +306,12 @@ public void downloadLink() throws Exception {
final URI downloadUri = new URI(downloadLink);
// Make sure that the download link works
- // Note that localstack produces a real AWS link so when testing
against localstack,
- // the link won't work
- final String realKey = System.getenv("AWS_ACCESS_KEY");
- final String realSecret = System.getenv("AWS_SECRET_KEY");
- final String realRegion = System.getenv("AWS_REGION");
- final boolean realCredentialsProvided = realKey != null &&
realSecret != null && realRegion != null;
- if (realCredentialsProvided) {
- RestAssured.given()
- .log().all()
- .contentType(ContentType.TEXT)
- .port(downloadUri.getPort())
- .get(downloadLink)
- .then()
- .statusCode(200)
- .body(is(blobContent));
- }
-
+ RestAssured.given()
+ .port(downloadUri.getPort())
+ .get(URLDecoder.decode(downloadLink,
StandardCharsets.UTF_8))
+ .then()
+ .statusCode(200)
+ .body(is(blobContent));
Review Comment:
So the donwload link could be availiable in the localstack since you add
```S3Presigner```?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]