JiriOndrusek commented on PR #7605: URL: https://github.com/apache/camel/pull/7605#issuecomment-1127642010
@davsclaus I'd say that both items are already prepared in this PR. Let me explain: --- ``` Because the endpoint-dsl is also changed (uri -> raw) then it would be good to have unit tests added there - you could potentially copy those examples you have and then make them use the EndpointRouteBuilder instead and build the URIs via that instead of normal URI strings https://github.com/apache/camel/tree/main/dsl/camel-endpointdsl ``` There are 2 test in camel-endpointdsl (`RawUrlWireTapDslTest` and `RawUrlPollEnrichTest`), they cover all changes caused by uri -> raw --- ``` Also it seems that wiretap has some special "simple" support which it checks at line 72 boolean simple = LanguageSupport.hasSimpleFunction(uri); I just wanted to ensure that if you use endpoint-dsl and have a simple function in the uri, that it still works. ``` Line 72 in wiretapReifier is covered by `RawUrlWireTapDslTest`. If the change in line 72 is reverted -> the test will fail (with "cannot convert simple function to integer"). --- I think that this misunderstanding was caused by the fact, that I separated the changes in 2 commits (with intension to make it easily understandable but the result was completely opposite) - I'm sorry for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
