JiriOndrusek opened a new pull request, #3815: URL: https://github.com/apache/camel-quarkus/pull/3815
fixes https://github.com/apache/camel-quarkus/issues/3741 This is not a complete coverage of the aws-secrets-manager component: - Test for operation `replicateSecretToRegions` is commented, because it causes internal error on localStack (it might be caused by missing configuration - needs to be investigated) - class `SecretsManagerPropertiesFunction` is not covered. As you can see [here](https://github.com/apache/camel/blob/main/components/camel-aws/camel-aws-secrets-manager/src/main/java/org/apache/camel/component/aws/secretsmanager/SecretsManagerPropertiesFunction.java#L91), aws client is configured from properties and url_override is not there. It has to be investigated how to cover this functionality. I changed `quarkus/test/support/aws2/Aws2TestEnvContext.java]` to support secrets-manager, but it means that it supports **aws-** (not aws**2**-..) component. I think that better approach would be to rename module to support/aws/ or create a new module for aws(not 2). On the other hand it would be a bigger change because a few lines of the code. I'm keeping this PR as draft and would like to ask, whether I should: 1. Create separated module for support-aws(not 2) 2. Rename current suuport/aws2/ to support/aws/ 3. Keep changes as it is Before I mark this draft as prepared to merge, I'll create tickets for missing parts of the test coverage. <!-- Uncomment and fill this section if your PR is not trivial [ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes. [ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #. [ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough. [ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea. [ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request. [ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
