astefanutti commented on code in PR #3366:
URL: https://github.com/apache/camel-k/pull/3366#discussion_r899024501
##########
pkg/builder/spectrum.go:
##########
@@ -124,6 +130,7 @@ func (t *spectrumTask) Do(ctx context.Context)
v1.BuildStatus {
Stdout: newStdW,
Stderr: newStdW,
Recursive: true,
+ jobs: Jobs,
Review Comment:
A suggestion could be:
```go
if jobs := runtime.GOMAXPROCS(0); jobs > 1 {
options.Jobs = jobs
}
```
##########
pkg/builder/spectrum.go:
##########
@@ -114,6 +115,11 @@ func (t *spectrumTask) Do(ctx context.Context)
v1.BuildStatus {
newStdW = os.Stdout
}
+ Jobs := jobs
Review Comment:
Does that compile?
##########
pkg/builder/spectrum.go:
##########
@@ -124,6 +130,7 @@ func (t *spectrumTask) Do(ctx context.Context)
v1.BuildStatus {
Stdout: newStdW,
Stderr: newStdW,
Recursive: true,
+ jobs: Jobs,
Review Comment:
It should probably be `Jobs` otherwise it's not public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
