christophd commented on code in PR #3400:
URL: https://github.com/apache/camel-k/pull/3400#discussion_r907712622
##########
pkg/install/knative.go:
##########
@@ -32,26 +32,26 @@ import (
const knativeAddressableResolverClusterRoleName = "addressable-resolver"
-// BindKnativeAddressableResolverClusterRole binds the Knative Addressable
resolver aggregated ClusterRole
+// BindKnativeAddressableResolverClusterRole binds the Knative addressable
resolver aggregated ClusterRole
// to the operator ServiceAccount.
-func BindKnativeAddressableResolverClusterRole(ctx context.Context, c
kubernetes.Interface, namespace string) error {
+func BindKnativeAddressableResolverClusterRole(ctx context.Context, c
kubernetes.Interface, namespace string, operatorNamespace string) error {
if isKnative, err := knative.IsInstalled(ctx, c); err != nil {
return err
} else if !isKnative {
return nil
}
if namespace != "" {
- return applyAddressableResolverRoleBinding(ctx, c, namespace)
+ return applyAddressableResolverRoleBinding(ctx, c, namespace,
operatorNamespace)
}
- return applyAddressableResolverClusterRoleBinding(ctx, c, namespace)
+ return applyAddressableResolverClusterRoleBinding(ctx, c,
operatorNamespace)
}
-func applyAddressableResolverRoleBinding(ctx context.Context, c
kubernetes.Interface, namespace string) error {
+func applyAddressableResolverRoleBinding(ctx context.Context, c
kubernetes.Interface, namespace string, operatorNamespace string) error {
rb := rbacv1ac.RoleBinding(fmt.Sprintf("%s-addressable-resolver",
serviceAccountName), namespace).
Review Comment:
so I could remove the operator namespace argument from the func again and
just use namespace. or the other way round
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
