christophd commented on code in PR #3402:
URL: https://github.com/apache/camel-k/pull/3402#discussion_r910750905
##########
pkg/trait/mount.go:
##########
@@ -118,13 +119,15 @@ func (t *mountTrait) Apply(e *Environment) error {
return err
}
- // CronJob
- if err := e.Resources.VisitCronJobE(func(cron *v1beta1.CronJob) error {
- volumes = &cron.Spec.JobTemplate.Spec.Template.Spec.Volumes
- visited = true
- return nil
- }); err != nil {
- return err
+ if ok, err := kubernetes.IsAPIResourceInstalled(e.Client,
batchv1.SchemeGroupVersion.String(), reflect.TypeOf(batchv1.CronJob{}).Name());
ok && err == nil {
Review Comment:
yes let's try without. makes life in tests much easier
##########
pkg/trait/container.go:
##########
@@ -297,17 +298,19 @@ func (t *containerTrait) configureContainer(e
*Environment) error {
return err
}
- // CronJob
- if err := e.Resources.VisitCronJobE(func(cron *v1beta1.CronJob) error {
- for _, envVar := range e.EnvVars {
- envvar.SetVar(&container.Env, envVar)
- }
+ if ok, err := kubernetes.IsAPIResourceInstalled(e.Client,
batchv1.SchemeGroupVersion.String(), reflect.TypeOf(batchv1.CronJob{}).Name());
ok && err == nil {
Review Comment:
yes let's try without. makes life in tests much easier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
