This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new f0be607e056 (chores) camel-jms tests: cleanups (#7956)
f0be607e056 is described below
commit f0be607e05652c637247ce5c6cafef1bab627335
Author: Otavio Rodolfo Piske <[email protected]>
AuthorDate: Thu Jun 30 17:40:31 2022 +0200
(chores) camel-jms tests: cleanups (#7956)
- simplify assertions
- reduce field scopes
- use final where possible
- avoid unnecessary calls to toString
- other minor cleanups
---
.../component/jms/AggregratedJmsRouteTest.java | 4 ++--
.../component/jms/ConsumeMessageConverterTest.java | 2 +-
.../jms/DefaultJmsHeaderKeyFormatStrategyTest.java | 2 +-
.../camel/component/jms/JmsAutoStartupTest.java | 6 +++---
.../camel/component/jms/JmsComponentTest.java | 15 ++++++++-------
.../jms/JmsEndpointConfigurationTest.java | 22 +++++++++++-----------
.../component/jms/JmsHeaderFilteringTest.java | 2 +-
.../jms/JmsInOnlyDisableTimeToLiveTest.java | 4 ++--
.../jms/JmsInOnlyInvalidDestinationTest.java | 2 +-
.../jms/JmsInOutDisableTimeToLiveTest.java | 4 ++--
.../jms/JmsInOutSynchronousFalseTest.java | 2 +-
.../component/jms/JmsInOutSynchronousTest.java | 2 +-
...ailoverWithForceSendOriginalJmsMessageTest.java | 2 +-
.../jms/JmsMessageCreatedStrategyEndpointTest.java | 2 +-
.../jms/JmsRequestReplyManualReplyTest.java | 2 +-
.../component/jms/JmsRouteRequestReplyTest.java | 4 ++--
.../JmsRouteWithCustomKeyFormatStrategyTest.java | 2 +-
.../JmsRouteWithCustomListenerContainerTest.java | 4 ++--
.../jms/JmsRouteWithInOnlyAndMultipleAcksTest.java | 10 ++++++----
.../component/jms/JmsRouteWithInOnlyTest.java | 2 +-
.../component/jms/JmsRoutingSlipInOutTest.java | 2 +-
.../jms/JmsThrottlingInflightRoutePolicyTest.java | 3 +--
.../jms/PassThroughJmsKeyFormatStrategyTest.java | 2 +-
.../component/jms/ProduceMessageConverterTest.java | 2 +-
.../apache/camel/component/jms/PurchaseOrder.java | 4 ++--
...RequestReplyCorrelatedWithCustomHeaderTest.java | 4 +---
.../camel/component/jms/discovery/MyRegistry.java | 2 +-
.../camel/component/jms/discovery/MyService.java | 2 +-
.../jms/issues/JmsAnotherCustomJMSReplyToTest.java | 4 ++--
.../jms/issues/JmsBeanMethodHeaderTest.java | 2 +-
.../issues/JmsConcurrentConsumerInOnlyTest.java | 3 +--
.../jms/issues/JmsCustomJMSReplyToIssueTest.java | 2 +-
.../jms/issues/JmsGetHeaderKeyFormatIssueTest.java | 2 +-
...derKeyFormatIssueWithContentTypeHeaderTest.java | 2 +-
.../jms/issues/JmsInOutPipelineWithBeanTest.java | 2 +-
.../component/jms/issues/JmsMutateMessageTest.java | 2 +-
.../issues/JmsMutateRemoveHeaderMessageTest.java | 2 +-
...roughtJmsKeyFormatStrategyEndUserIssueTest.java | 2 +-
...ssThroughtJmsKeyFormatStrategyEndpointTest.java | 2 +-
.../JmsPassThroughtJmsKeyFormatStrategyTest.java | 2 +-
...KeyFormatStrategyUsingJmsConfigurationTest.java | 2 +-
.../jms/issues/JmsReplyToLoopIssueTest.java | 2 +-
...endToAlotOfDestinationWithSameEndpointTest.java | 2 +-
...tReplyTemporaryRefreshFailureOnStartupTest.java | 2 +-
.../jms/tuning/PerformanceRoutePojoTest.java | 3 +--
.../component/jms/tuning/PerformanceRouteTest.java | 3 +--
.../jms/tx/ConditionalExceptionProcessor.java | 2 +-
.../JMSTransactionThrottlingRoutePolicyTest.java | 3 +--
48 files changed, 79 insertions(+), 83 deletions(-)
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/AggregratedJmsRouteTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/AggregratedJmsRouteTest.java
index e2e5cb85a6b..a4961569f79 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/AggregratedJmsRouteTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/AggregratedJmsRouteTest.java
@@ -35,8 +35,8 @@ import static org.junit.jupiter.api.Assertions.fail;
public class AggregratedJmsRouteTest extends CamelTestSupport {
private static final Logger LOG =
LoggerFactory.getLogger(AggregratedJmsRouteTest.class);
- private String timeOutEndpointUri = "jms:queue:test.a";
- private String multicastEndpointUri = "jms:queue:multicast";
+ private final String timeOutEndpointUri = "jms:queue:test.a";
+ private final String multicastEndpointUri = "jms:queue:multicast";
/*
* negative receive wait timeout for jms is blocking so timeout during
processing does not hang
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/ConsumeMessageConverterTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/ConsumeMessageConverterTest.java
index bc34082c468..c78cfbf9b1d 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/ConsumeMessageConverterTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/ConsumeMessageConverterTest.java
@@ -37,7 +37,7 @@ import static
org.apache.camel.component.jms.JmsComponent.jmsComponentAutoAcknow
public class ConsumeMessageConverterTest extends CamelTestSupport {
@BindToRegistry("myMessageConverter")
- private MyMessageConverter conv = new MyMessageConverter();
+ private final MyMessageConverter conv = new MyMessageConverter();
@Override
protected CamelContext createCamelContext() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/DefaultJmsHeaderKeyFormatStrategyTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/DefaultJmsHeaderKeyFormatStrategyTest.java
index a83ae1448eb..5f100d45e8a 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/DefaultJmsHeaderKeyFormatStrategyTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/DefaultJmsHeaderKeyFormatStrategyTest.java
@@ -22,7 +22,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
public class DefaultJmsHeaderKeyFormatStrategyTest {
- private JmsKeyFormatStrategy strategy = new DefaultJmsKeyFormatStrategy();
+ private final JmsKeyFormatStrategy strategy = new
DefaultJmsKeyFormatStrategy();
@Test
public void testEncodeValidKeys() {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsAutoStartupTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsAutoStartupTest.java
index a87f3ba1641..f621689ee06 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsAutoStartupTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsAutoStartupTest.java
@@ -29,7 +29,7 @@ import org.awaitility.Awaitility;
import org.junit.jupiter.api.Test;
import static
org.apache.camel.component.jms.JmsComponent.jmsComponentAutoAcknowledge;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
public class JmsAutoStartupTest extends CamelTestSupport {
@@ -40,7 +40,7 @@ public class JmsAutoStartupTest extends CamelTestSupport {
Service service = context.getRoutes().get(0).getServices().get(0);
JmsConsumer consumer = (JmsConsumer) service;
- assertEquals(false, consumer.getListenerContainer().isRunning());
+ assertFalse(consumer.getListenerContainer().isRunning());
MockEndpoint mock = getMockEndpoint("mock:result");
// should be stopped by default
@@ -49,7 +49,7 @@ public class JmsAutoStartupTest extends CamelTestSupport {
template.sendBody("activemq:queue:foo", "Hello World");
Awaitility.await().atMost(2, TimeUnit.SECONDS)
- .untilAsserted(() -> assertMockEndpointsSatisfied());
+ .untilAsserted(this::assertMockEndpointsSatisfied);
mock.reset();
mock.expectedBodiesReceived("Hello World");
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsComponentTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsComponentTest.java
index de8c1b78e92..02479b8ab01 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsComponentTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsComponentTest.java
@@ -25,6 +25,7 @@ import org.junit.jupiter.api.Test;
import static
org.apache.camel.component.jms.JmsComponent.jmsComponentAutoAcknowledge;
import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
public class JmsComponentTest extends CamelTestSupport {
@@ -36,16 +37,16 @@ public class JmsComponentTest extends CamelTestSupport {
String reply =
template.requestBody("activemq123:queue:hello?requestTimeout=5000", "Hello
World", String.class);
assertEquals("Bye World", reply);
- assertEquals(true, endpoint.isAcceptMessagesWhileStopping());
- assertEquals(true, endpoint.isAllowReplyManagerQuickStop());
- assertEquals(true, endpoint.isAlwaysCopyMessage());
+ assertTrue(endpoint.isAcceptMessagesWhileStopping());
+ assertTrue(endpoint.isAllowReplyManagerQuickStop());
+ assertTrue(endpoint.isAlwaysCopyMessage());
assertEquals(1, endpoint.getAcknowledgementMode());
- assertEquals(true, endpoint.isAutoStartup());
+ assertTrue(endpoint.isAutoStartup());
assertEquals(1, endpoint.getCacheLevel());
assertEquals("foo", endpoint.getClientId());
assertEquals(2, endpoint.getConcurrentConsumers());
- assertEquals(true, endpoint.isDeliveryPersistent());
- assertEquals(true, endpoint.isExplicitQosEnabled());
+ assertTrue(endpoint.isDeliveryPersistent());
+ assertTrue(endpoint.isExplicitQosEnabled());
assertEquals(20, endpoint.getIdleTaskExecutionLimit());
assertEquals(21, endpoint.getIdleConsumerLimit());
assertEquals(5, endpoint.getMaxConcurrentConsumers());
@@ -54,7 +55,7 @@ public class JmsComponentTest extends CamelTestSupport {
assertEquals(5000, endpoint.getReceiveTimeout());
assertEquals(9000, endpoint.getRecoveryInterval());
assertEquals(3000, endpoint.getTimeToLive());
- assertEquals(true, endpoint.isTransacted());
+ assertTrue(endpoint.isTransacted());
assertEquals(15000, endpoint.getTransactionTimeout());
}
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsEndpointConfigurationTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsEndpointConfigurationTest.java
index ce5a5cf8ff5..9cbde9949b4 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsEndpointConfigurationTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsEndpointConfigurationTest.java
@@ -53,7 +53,7 @@ public class JmsEndpointConfigurationTest extends
CamelTestSupport {
private static final Logger LOG =
LoggerFactory.getLogger(ConsumeJmsMapMessageTest.class);
@BindToRegistry("myConnectionFactory")
- private ActiveMQConnectionFactory factory = new
ActiveMQConnectionFactory("vm:myBroker");
+ private final ActiveMQConnectionFactory factory = new
ActiveMQConnectionFactory("vm:myBroker");
private final Processor failProcessor = exchange -> fail("Should not be
reached");
private final Processor dummyProcessor = exchange -> LOG.info("Received: "
+ exchange);
@@ -77,14 +77,14 @@ public class JmsEndpointConfigurationTest extends
CamelTestSupport {
JmsEndpoint endpoint = resolveMandatoryEndpoint(
"jms:topic:Foo.Bar?subscriptionDurable=true&subscriptionShared=true&subscriptionName=James",
JmsEndpoint.class);
JmsConfiguration configuration = endpoint.getConfiguration();
- assertEquals(true, configuration.isSubscriptionDurable(),
"isSubscriptionDurable()");
- assertEquals(true, configuration.isSubscriptionShared(),
"isSubscriptionShared()");
+ assertTrue(configuration.isSubscriptionDurable(),
"isSubscriptionDurable()");
+ assertTrue(configuration.isSubscriptionShared(),
"isSubscriptionShared()");
assertEquals("James", configuration.getSubscriptionName(),
"getSubscriptionName()");
JmsConsumer consumer = endpoint.createConsumer(exchange ->
LOG.info("Received: " + exchange));
AbstractMessageListenerContainer listenerContainer =
consumer.getListenerContainer();
- assertEquals(true, listenerContainer.isSubscriptionDurable(),
"isSubscriptionDurable()");
- assertEquals(true, listenerContainer.isSubscriptionShared(),
"isSubscriptionShared()");
+ assertTrue(listenerContainer.isSubscriptionDurable(),
"isSubscriptionDurable()");
+ assertTrue(listenerContainer.isSubscriptionShared(),
"isSubscriptionShared()");
assertEquals("James", listenerContainer.getSubscriptionName(),
"getSubscriptionName()");
}
@@ -93,14 +93,14 @@ public class JmsEndpointConfigurationTest extends
CamelTestSupport {
JmsEndpoint endpoint =
resolveMandatoryEndpoint("jms:topic:Foo.Bar?subscriptionShared=true&subscriptionName=James",
JmsEndpoint.class);
JmsConfiguration configuration = endpoint.getConfiguration();
- assertEquals(false, configuration.isSubscriptionDurable(),
"isSubscriptionDurable()");
- assertEquals(true, configuration.isSubscriptionShared(),
"isSubscriptionShared()");
+ assertFalse(configuration.isSubscriptionDurable(),
"isSubscriptionDurable()");
+ assertTrue(configuration.isSubscriptionShared(),
"isSubscriptionShared()");
assertEquals("James", configuration.getSubscriptionName(),
"getSubscriptionName()");
JmsConsumer consumer = endpoint.createConsumer(exchange ->
LOG.info("Received: " + exchange));
AbstractMessageListenerContainer listenerContainer =
consumer.getListenerContainer();
- assertEquals(false, listenerContainer.isSubscriptionDurable(),
"isSubscriptionDurable()");
- assertEquals(true, listenerContainer.isSubscriptionShared(),
"isSubscriptionShared()");
+ assertFalse(listenerContainer.isSubscriptionDurable(),
"isSubscriptionDurable()");
+ assertTrue(listenerContainer.isSubscriptionShared(),
"isSubscriptionShared()");
assertEquals("James", listenerContainer.getSubscriptionName(),
"getSubscriptionName()");
}
@@ -540,13 +540,13 @@ public class JmsEndpointConfigurationTest extends
CamelTestSupport {
JmsConfiguration configuration = endpoint.getConfiguration();
assertEquals("James", configuration.getDurableSubscriptionName(),
"getDurableSubscriptionName()");
assertEquals("ABC", configuration.getClientId(), "getClientId()");
- assertEquals(true, configuration.isDeliveryPersistent(),
"isDeliveryPersistent()");
+ assertTrue(configuration.isDeliveryPersistent(),
"isDeliveryPersistent()");
JmsConsumer consumer = endpoint.createConsumer(exchange ->
LOG.info("Received: " + exchange));
AbstractMessageListenerContainer listenerContainer =
consumer.getListenerContainer();
assertEquals("James", listenerContainer.getDurableSubscriptionName(),
"getDurableSubscriptionName()");
assertEquals("ABC", listenerContainer.getClientId(), "getClientId()");
- assertEquals(true, listenerContainer.isSubscriptionDurable(),
"isSubscriptionDurable()");
+ assertTrue(listenerContainer.isSubscriptionDurable(),
"isSubscriptionDurable()");
}
@Override
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsHeaderFilteringTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsHeaderFilteringTest.java
index 31932b70f4d..d715713a351 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsHeaderFilteringTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsHeaderFilteringTest.java
@@ -43,7 +43,7 @@ public class JmsHeaderFilteringTest extends CamelTestSupport {
private final String testQueueEndpointA = componentName + ":queue:test.a";
private final String testQueueEndpointB = componentName + ":queue:test.b";
private final String assertionReceiver = "mock:errors";
- private CountDownLatch latch = new CountDownLatch(2);
+ private final CountDownLatch latch = new CountDownLatch(2);
@Test
public void testHeaderFilters() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOnlyDisableTimeToLiveTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOnlyDisableTimeToLiveTest.java
index a357bb77b54..afbc8d1caff 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOnlyDisableTimeToLiveTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOnlyDisableTimeToLiveTest.java
@@ -29,8 +29,8 @@ import static
org.apache.camel.component.jms.JmsComponent.jmsComponentAutoAcknow
public class JmsInOnlyDisableTimeToLiveTest extends CamelTestSupport {
- private String urlTimeout = "activemq:queue.in?timeToLive=2000";
- private String urlTimeToLiveDisabled =
"activemq:queue.in?timeToLive=2000&disableTimeToLive=true";
+ private final String urlTimeout = "activemq:queue.in?timeToLive=2000";
+ private final String urlTimeToLiveDisabled =
"activemq:queue.in?timeToLive=2000&disableTimeToLive=true";
@Test
public void testInOnlyExpired() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOnlyInvalidDestinationTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOnlyInvalidDestinationTest.java
index 4843b954f51..74d88de7438 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOnlyInvalidDestinationTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOnlyInvalidDestinationTest.java
@@ -37,7 +37,7 @@ import static
org.apache.camel.component.jms.JmsComponent.jmsComponentAutoAcknow
public class JmsInOnlyInvalidDestinationTest extends CamelTestSupport {
@BindToRegistry("myResolver")
- private MyDestinationResolver resolver = new MyDestinationResolver();
+ private final MyDestinationResolver resolver = new MyDestinationResolver();
@Test
public void testInvalidDestination() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutDisableTimeToLiveTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutDisableTimeToLiveTest.java
index c7310b10a0f..08f518175df 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutDisableTimeToLiveTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutDisableTimeToLiveTest.java
@@ -31,8 +31,8 @@ import static org.junit.jupiter.api.Assertions.fail;
public class JmsInOutDisableTimeToLiveTest extends CamelTestSupport {
- private String urlTimeout = "activemq:queue.in?requestTimeout=2000";
- private String urlTimeToLiveDisabled =
"activemq:queue.in?requestTimeout=2000&disableTimeToLive=true";
+ private final String urlTimeout = "activemq:queue.in?requestTimeout=2000";
+ private final String urlTimeToLiveDisabled =
"activemq:queue.in?requestTimeout=2000&disableTimeToLive=true";
@Test
public void testInOutExpired() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutSynchronousFalseTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutSynchronousFalseTest.java
index 4941064f98f..a1abf4186e9 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutSynchronousFalseTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutSynchronousFalseTest.java
@@ -31,7 +31,7 @@ public class JmsInOutSynchronousFalseTest extends
CamelTestSupport {
private static String beforeThreadName;
private static String afterThreadName;
- private String url = "activemq:queue:in?synchronous=false";
+ private final String url = "activemq:queue:in?synchronous=false";
@Test
public void testSynchronous() {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutSynchronousTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutSynchronousTest.java
index 912402fb638..7af56ddfddd 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutSynchronousTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOutSynchronousTest.java
@@ -31,7 +31,7 @@ public class JmsInOutSynchronousTest extends CamelTestSupport
{
private static String beforeThreadName;
private static String afterThreadName;
- private String url = "activemq:queue:in?synchronous=true";
+ private final String url = "activemq:queue:in?synchronous=true";
@Test
public void testSynchronous() {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsLoadBalanceFailoverWithForceSendOriginalJmsMessageTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsLoadBalanceFailoverWithForceSendOriginalJmsMessageTest.java
index 302da3b59ed..79f7d3d74ec 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsLoadBalanceFailoverWithForceSendOriginalJmsMessageTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsLoadBalanceFailoverWithForceSendOriginalJmsMessageTest.java
@@ -32,7 +32,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
* Unit test for Camel loadbalancer failover with JMS
*/
public class JmsLoadBalanceFailoverWithForceSendOriginalJmsMessageTest extends
CamelTestSupport {
- private boolean forceSendOriginalMessage = true;
+ private final boolean forceSendOriginalMessage = true;
@Test
public void testFailover() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsMessageCreatedStrategyEndpointTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsMessageCreatedStrategyEndpointTest.java
index 16b5b3240dc..96c703a4253 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsMessageCreatedStrategyEndpointTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsMessageCreatedStrategyEndpointTest.java
@@ -36,7 +36,7 @@ public class JmsMessageCreatedStrategyEndpointTest extends
CamelTestSupport {
protected String componentName = "activemq";
@BindToRegistry("myStrategy")
- private MyMessageCreatedStrategy strategy = new MyMessageCreatedStrategy();
+ private final MyMessageCreatedStrategy strategy = new
MyMessageCreatedStrategy();
@Test
public void testMessageCreatedStrategy() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyManualReplyTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyManualReplyTest.java
index 7e9faa1954f..0e5bb1b804c 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyManualReplyTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRequestReplyManualReplyTest.java
@@ -39,7 +39,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
public class JmsRequestReplyManualReplyTest extends CamelTestSupport {
private static volatile String tempName;
- private CountDownLatch latch = new CountDownLatch(1);
+ private final CountDownLatch latch = new CountDownLatch(1);
private JmsTemplate jms;
@Override
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteRequestReplyTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteRequestReplyTest.java
index 1cc7ec1f657..1ebc010dd37 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteRequestReplyTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteRequestReplyTest.java
@@ -259,8 +259,8 @@ public class JmsRouteRequestReplyTest extends
CamelTestSupport {
}
public class Task implements Callable<Task> {
- private AtomicInteger counter;
- private String fromUri;
+ private final AtomicInteger counter;
+ private final String fromUri;
private volatile boolean ok = true;
private volatile String message = "";
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithCustomKeyFormatStrategyTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithCustomKeyFormatStrategyTest.java
index 24bfa0abe80..fd4f7d75f22 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithCustomKeyFormatStrategyTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithCustomKeyFormatStrategyTest.java
@@ -26,7 +26,7 @@ import org.apache.camel.util.StringHelper;
public class JmsRouteWithCustomKeyFormatStrategyTest extends
JmsRouteWithDefaultKeyFormatStrategyTest {
@BindToRegistry("myJmsKeyStrategy")
- private MyCustomKeyFormatStrategy strategy = new
MyCustomKeyFormatStrategy();
+ private final MyCustomKeyFormatStrategy strategy = new
MyCustomKeyFormatStrategy();
@Override
protected String getUri() {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithCustomListenerContainerTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithCustomListenerContainerTest.java
index af1b769af7e..c18734456c8 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithCustomListenerContainerTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithCustomListenerContainerTest.java
@@ -40,10 +40,10 @@ public class JmsRouteWithCustomListenerContainerTest
extends CamelTestSupport {
protected String componentName = "activemq";
@BindToRegistry("orderService")
- private MyOrderServiceBean serviceBean = new MyOrderServiceBean();
+ private final MyOrderServiceBean serviceBean = new MyOrderServiceBean();
@BindToRegistry("myListenerContainerFactory")
- private MyListenerContainerFactory containerFact = new
MyListenerContainerFactory();
+ private final MyListenerContainerFactory containerFact = new
MyListenerContainerFactory();
@Test
public void testSendOrder() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithInOnlyAndMultipleAcksTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithInOnlyAndMultipleAcksTest.java
index 03a8e1e1a82..8d0dc59da80 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithInOnlyAndMultipleAcksTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithInOnlyAndMultipleAcksTest.java
@@ -34,13 +34,15 @@ public class JmsRouteWithInOnlyAndMultipleAcksTest extends
CamelTestSupport {
protected String componentName = "amq";
@BindToRegistry("orderService")
- private MyOrderServiceBean serviceBean = new MyOrderServiceBean();
+ private final MyOrderServiceBean serviceBean = new MyOrderServiceBean();
@BindToRegistry("orderServiceNotificationWithAck-1")
- private MyOrderServiceNotificationWithAckBean orderNotificationAckBean =
new MyOrderServiceNotificationWithAckBean("1");
+ private final MyOrderServiceNotificationWithAckBean
orderNotificationAckBean
+ = new MyOrderServiceNotificationWithAckBean("1");
@BindToRegistry("orderServiceNotificationWithAck-2")
- private MyOrderServiceNotificationWithAckBean orderNotificationAckBean2 =
new MyOrderServiceNotificationWithAckBean("2");
+ private final MyOrderServiceNotificationWithAckBean
orderNotificationAckBean2
+ = new MyOrderServiceNotificationWithAckBean("2");
@Test
public void testSendOrderWithMultipleAcks() throws Exception {
@@ -108,7 +110,7 @@ public class JmsRouteWithInOnlyAndMultipleAcksTest extends
CamelTestSupport {
}
public static class MyOrderServiceNotificationWithAckBean {
- private String id;
+ private final String id;
public MyOrderServiceNotificationWithAckBean(String id) {
this.id = id;
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithInOnlyTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithInOnlyTest.java
index 039e38659ea..f190174eb55 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithInOnlyTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithInOnlyTest.java
@@ -37,7 +37,7 @@ public class JmsRouteWithInOnlyTest extends CamelTestSupport {
protected String componentName = "activemq";
@BindToRegistry("orderService")
- private MyOrderServiceBean serviceBean = new MyOrderServiceBean();
+ private final MyOrderServiceBean serviceBean = new MyOrderServiceBean();
@Test
public void testSendOrder() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRoutingSlipInOutTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRoutingSlipInOutTest.java
index 2457cb9e4e2..590219816cd 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRoutingSlipInOutTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRoutingSlipInOutTest.java
@@ -36,7 +36,7 @@ import static
org.apache.camel.component.jms.JmsComponent.jmsComponentAutoAcknow
public class JmsRoutingSlipInOutTest extends CamelTestSupport {
@BindToRegistry("myBean")
- private MyBean bean = new MyBean();
+ private final MyBean bean = new MyBean();
@Test
public void testInOutRoutingSlip() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsThrottlingInflightRoutePolicyTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsThrottlingInflightRoutePolicyTest.java
index 93c08984f02..8c57cecdb49 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsThrottlingInflightRoutePolicyTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsThrottlingInflightRoutePolicyTest.java
@@ -29,11 +29,10 @@ import static
org.apache.camel.component.jms.JmsComponent.jmsComponentTransacted
public class JmsThrottlingInflightRoutePolicyTest extends CamelTestSupport {
- private int size = 200;
-
@Test
public void testJmsThrottlingInflightRoutePolicy() throws Exception {
MockEndpoint mock = getMockEndpoint("mock:result");
+ int size = 200;
mock.expectedMinimumMessageCount(size);
for (int i = 0; i < size; i++) {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/PassThroughJmsKeyFormatStrategyTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/PassThroughJmsKeyFormatStrategyTest.java
index 1af46a0624e..1af89826ee9 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/PassThroughJmsKeyFormatStrategyTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/PassThroughJmsKeyFormatStrategyTest.java
@@ -22,7 +22,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
public class PassThroughJmsKeyFormatStrategyTest {
- private JmsKeyFormatStrategy strategy = new
PassThroughJmsKeyFormatStrategy();
+ private final JmsKeyFormatStrategy strategy = new
PassThroughJmsKeyFormatStrategy();
@Test
public void testEncodeValidKeys() {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/ProduceMessageConverterTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/ProduceMessageConverterTest.java
index 7f489d4a209..0195cd4c568 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/ProduceMessageConverterTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/ProduceMessageConverterTest.java
@@ -36,7 +36,7 @@ import static
org.apache.camel.component.jms.JmsComponent.jmsComponentAutoAcknow
public class ProduceMessageConverterTest extends CamelTestSupport {
@BindToRegistry("myMessageConverter")
- private MyMessageConverter conv = new MyMessageConverter();
+ private final MyMessageConverter conv = new MyMessageConverter();
@Override
protected CamelContext createCamelContext() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/PurchaseOrder.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/PurchaseOrder.java
index 743249e0278..8cb487da1e9 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/PurchaseOrder.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/PurchaseOrder.java
@@ -23,8 +23,8 @@ import java.io.Serializable;
*/
public class PurchaseOrder implements Serializable {
private static final long serialVersionUID = 1L;
- private String product;
- private double amount;
+ private final String product;
+ private final double amount;
public PurchaseOrder(String product, double amount) {
this.product = product;
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/RequestReplyCorrelatedWithCustomHeaderTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/RequestReplyCorrelatedWithCustomHeaderTest.java
index 87d0f2377d1..824368fb4c8 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/RequestReplyCorrelatedWithCustomHeaderTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/RequestReplyCorrelatedWithCustomHeaderTest.java
@@ -34,8 +34,6 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
public class RequestReplyCorrelatedWithCustomHeaderTest extends
CamelTestSupport {
- private ConnectionFactory connectionFactory;
-
public static void processRequest(
@Body final String body,
@Header("CustomCorrelation") final String customCorrelation,
@@ -66,7 +64,7 @@ public class RequestReplyCorrelatedWithCustomHeaderTest
extends CamelTestSupport
protected CamelContext createCamelContext() throws Exception {
final CamelContext camelContext = super.createCamelContext();
- connectionFactory = CamelJmsTestHelper.createConnectionFactory();
+ ConnectionFactory connectionFactory =
CamelJmsTestHelper.createConnectionFactory();
final JmsComponent activeMq =
jmsComponentAutoAcknowledge(connectionFactory);
activeMq.getConfiguration().setCorrelationProperty("CustomCorrelation");
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/discovery/MyRegistry.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/discovery/MyRegistry.java
index 0f1cf49d644..94a930dd1ed 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/discovery/MyRegistry.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/discovery/MyRegistry.java
@@ -28,7 +28,7 @@ import org.slf4j.LoggerFactory;
public class MyRegistry {
private static final Logger LOG =
LoggerFactory.getLogger(MyRegistry.class);
- private Map<String, Map<String, Object>> services = new HashMap<>();
+ private final Map<String, Map<String, Object>> services = new HashMap<>();
public void onEvent(Map<String, Object> heartbeat) {
String key = (String) heartbeat.get("name");
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/discovery/MyService.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/discovery/MyService.java
index 815fdf41d0f..5aa043fc7f9 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/discovery/MyService.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/discovery/MyService.java
@@ -21,7 +21,7 @@ import java.util.HashMap;
import java.util.Map;
public class MyService {
- private String name;
+ private final String name;
public MyService(String name) {
this.name = name;
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsAnotherCustomJMSReplyToTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsAnotherCustomJMSReplyToTest.java
index d264964f8f8..222dab60531 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsAnotherCustomJMSReplyToTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsAnotherCustomJMSReplyToTest.java
@@ -59,9 +59,9 @@ public class JmsAnotherCustomJMSReplyToTest extends
CamelTestSupport {
assertEquals("queue://nameReplyQueue", replyTo.toString());
// send reply
- template.sendBody("activemq:" + replyTo.toString(), "My name is
Arnio");
+ template.sendBody("activemq:" + replyTo, "My name is Arnio");
- Awaitility.await().atMost(2, TimeUnit.SECONDS).untilAsserted(() ->
assertMockEndpointsSatisfied());
+ Awaitility.await().atMost(2,
TimeUnit.SECONDS).untilAsserted(this::assertMockEndpointsSatisfied);
}
@Override
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsBeanMethodHeaderTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsBeanMethodHeaderTest.java
index c23a2b74ebf..d61fe9dcc06 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsBeanMethodHeaderTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsBeanMethodHeaderTest.java
@@ -37,7 +37,7 @@ import static
org.apache.camel.component.jms.JmsComponent.jmsComponentAutoAcknow
public class JmsBeanMethodHeaderTest extends CamelTestSupport {
@BindToRegistry("approveService")
- private ApproveService service = new ApproveService();
+ private final ApproveService service = new ApproveService();
@Test
public void testPlainHeader() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsConcurrentConsumerInOnlyTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsConcurrentConsumerInOnlyTest.java
index b23c81dfc38..b73781ccd7e 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsConcurrentConsumerInOnlyTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsConcurrentConsumerInOnlyTest.java
@@ -31,11 +31,10 @@ import static
org.apache.camel.component.jms.JmsComponent.jmsComponentAutoAcknow
*/
public class JmsConcurrentConsumerInOnlyTest extends CamelTestSupport {
- private int size = 2000;
-
@Test
public void testConcurrentConsumers() throws Exception {
// send messages to queue before processing
+ int size = 2000;
for (int i = 0; i < size; i++) {
template.sendBody("activemq:foo", "Hello " + i);
}
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsCustomJMSReplyToIssueTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsCustomJMSReplyToIssueTest.java
index fcc32a60582..3a234e9ae1a 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsCustomJMSReplyToIssueTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsCustomJMSReplyToIssueTest.java
@@ -56,7 +56,7 @@ public class JmsCustomJMSReplyToIssueTest extends
CamelTestSupport {
assertEquals("queue://myReplyQueue", replyTo.toString());
// send reply
- template.sendBody("activemq:" + replyTo.toString(), "Bye World");
+ template.sendBody("activemq:" + replyTo, "Bye World");
assertMockEndpointsSatisfied();
}
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsGetHeaderKeyFormatIssueTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsGetHeaderKeyFormatIssueTest.java
index 08104f37f19..1b622b135c5 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsGetHeaderKeyFormatIssueTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsGetHeaderKeyFormatIssueTest.java
@@ -32,7 +32,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
public class JmsGetHeaderKeyFormatIssueTest extends CamelTestSupport {
- private String uri = "activemq:queue:hello?jmsKeyFormatStrategy=default";
+ private final String uri =
"activemq:queue:hello?jmsKeyFormatStrategy=default";
@Test
public void testSendWithHeaders() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsGetHeaderKeyFormatIssueWithContentTypeHeaderTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsGetHeaderKeyFormatIssueWithContentTypeHeaderTest.java
index cff92da4d40..116727fc12a 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsGetHeaderKeyFormatIssueWithContentTypeHeaderTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsGetHeaderKeyFormatIssueWithContentTypeHeaderTest.java
@@ -37,7 +37,7 @@ import static org.junit.jupiter.api.Assertions.assertNotNull;
*/
public class JmsGetHeaderKeyFormatIssueWithContentTypeHeaderTest extends
CamelTestSupport {
- private String uri = "activemq:queue:hello?jmsKeyFormatStrategy=default";
+ private final String uri =
"activemq:queue:hello?jmsKeyFormatStrategy=default";
@Test
public void testSendWithHeaders() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsInOutPipelineWithBeanTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsInOutPipelineWithBeanTest.java
index 4e6d5e9914e..dd1476a4ba2 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsInOutPipelineWithBeanTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsInOutPipelineWithBeanTest.java
@@ -35,7 +35,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
public class JmsInOutPipelineWithBeanTest extends CamelTestSupport {
@BindToRegistry("dummyBean")
- private MyDummyBean bean = new MyDummyBean();
+ private final MyDummyBean bean = new MyDummyBean();
@Test
public void testA() {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsMutateMessageTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsMutateMessageTest.java
index 7ca6bd1386a..d028c8b0245 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsMutateMessageTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsMutateMessageTest.java
@@ -33,7 +33,7 @@ import static org.junit.jupiter.api.Assertions.assertNotNull;
public class JmsMutateMessageTest extends CamelTestSupport {
- private String uri = "activemq:queue:hello";
+ private final String uri = "activemq:queue:hello";
@Test
public void testMutateMessage() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsMutateRemoveHeaderMessageTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsMutateRemoveHeaderMessageTest.java
index 6af3eddde6f..df44367ea4e 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsMutateRemoveHeaderMessageTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsMutateRemoveHeaderMessageTest.java
@@ -34,7 +34,7 @@ import static org.junit.jupiter.api.Assertions.assertNull;
public class JmsMutateRemoveHeaderMessageTest extends CamelTestSupport {
- private String uri = "activemq:queue:hello";
+ private final String uri = "activemq:queue:hello";
@Test
public void testMutateMessage() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsPassThroughtJmsKeyFormatStrategyEndUserIssueTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsPassThroughtJmsKeyFormatStrategyEndUserIssueTest.java
index 1f827ab8b52..13769ba4c7c 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsPassThroughtJmsKeyFormatStrategyEndUserIssueTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsPassThroughtJmsKeyFormatStrategyEndUserIssueTest.java
@@ -32,7 +32,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
public class JmsPassThroughtJmsKeyFormatStrategyEndUserIssueTest extends
CamelTestSupport {
- private String uri =
"activemq:queue:hello?jmsKeyFormatStrategy=passthrough";
+ private final String uri =
"activemq:queue:hello?jmsKeyFormatStrategy=passthrough";
@Test
public void testSendWithHeaders() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsPassThroughtJmsKeyFormatStrategyEndpointTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsPassThroughtJmsKeyFormatStrategyEndpointTest.java
index b7e41d970fe..bc60ffe418e 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsPassThroughtJmsKeyFormatStrategyEndpointTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsPassThroughtJmsKeyFormatStrategyEndpointTest.java
@@ -32,7 +32,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
public class JmsPassThroughtJmsKeyFormatStrategyEndpointTest extends
CamelTestSupport {
- private String uri =
"activemq:queue:hello?jmsKeyFormatStrategy=passthrough";
+ private final String uri =
"activemq:queue:hello?jmsKeyFormatStrategy=passthrough";
@Test
public void testSendWithHeaders() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsPassThroughtJmsKeyFormatStrategyTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsPassThroughtJmsKeyFormatStrategyTest.java
index 2dd332b962d..66fa7d7f3b0 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsPassThroughtJmsKeyFormatStrategyTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsPassThroughtJmsKeyFormatStrategyTest.java
@@ -34,7 +34,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
public class JmsPassThroughtJmsKeyFormatStrategyTest extends CamelTestSupport {
- private String uri = "activemq:queue:hello";
+ private final String uri = "activemq:queue:hello";
@Test
public void testSendWithHeaders() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsPassThroughtJmsKeyFormatStrategyUsingJmsConfigurationTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsPassThroughtJmsKeyFormatStrategyUsingJmsConfigurationTest.java
index bf2240a5fd3..0b8b2630347 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsPassThroughtJmsKeyFormatStrategyUsingJmsConfigurationTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsPassThroughtJmsKeyFormatStrategyUsingJmsConfigurationTest.java
@@ -34,7 +34,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
public class JmsPassThroughtJmsKeyFormatStrategyUsingJmsConfigurationTest
extends CamelTestSupport {
- private String uri = "activemq:queue:hello";
+ private final String uri = "activemq:queue:hello";
@Test
public void testSendWithHeaders() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsReplyToLoopIssueTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsReplyToLoopIssueTest.java
index 4adb84bce5a..cc9a55bf28d 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsReplyToLoopIssueTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsReplyToLoopIssueTest.java
@@ -40,7 +40,7 @@ public class JmsReplyToLoopIssueTest extends CamelTestSupport
{
template.sendBodyAndHeader("direct:start", "World", "JMSReplyTo",
"queue:bar");
// sleep a little to ensure we do not do endless loop
- Awaitility.await().atMost(250, TimeUnit.MILLISECONDS).untilAsserted(()
-> assertMockEndpointsSatisfied());
+ Awaitility.await().atMost(250,
TimeUnit.MILLISECONDS).untilAsserted(this::assertMockEndpointsSatisfied);
}
@Override
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsSendToAlotOfDestinationWithSameEndpointTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsSendToAlotOfDestinationWithSameEndpointTest.java
index 1a72136cca2..c19fd0111fd 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsSendToAlotOfDestinationWithSameEndpointTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsSendToAlotOfDestinationWithSameEndpointTest.java
@@ -34,7 +34,7 @@ public class JmsSendToAlotOfDestinationWithSameEndpointTest
extends CamelSpringT
@Test
public void testSendToAlotOfMessageToQueues() {
- assertDoesNotThrow(() -> sendToAlotOfMessagesToQueue());
+ assertDoesNotThrow(this::sendToAlotOfMessagesToQueue);
// now we should be able to poll a message from each queue
// Thread.sleep(99999999);
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/temp/JmsRequestReplyTemporaryRefreshFailureOnStartupTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/temp/JmsRequestReplyTemporaryRefreshFailureOnStartupTest.java
index 2dda288bbce..7274316c2bb 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/temp/JmsRequestReplyTemporaryRefreshFailureOnStartupTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/temp/JmsRequestReplyTemporaryRefreshFailureOnStartupTest.java
@@ -35,7 +35,7 @@ import static
org.apache.camel.component.jms.JmsComponent.jmsComponentAutoAcknow
public class JmsRequestReplyTemporaryRefreshFailureOnStartupTest extends
CamelTestSupport {
private String brokerName;
- private Long recoveryInterval = 1000L;
+ private final Long recoveryInterval = 1000L;
@Override
protected CamelContext createCamelContext() throws Exception {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/tuning/PerformanceRoutePojoTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/tuning/PerformanceRoutePojoTest.java
index 7308548e3de..8e85e14957f 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/tuning/PerformanceRoutePojoTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/tuning/PerformanceRoutePojoTest.java
@@ -29,8 +29,6 @@ public class PerformanceRoutePojoTest extends
CamelSpringTestSupport {
private static final Logger LOG =
LoggerFactory.getLogger(PerformanceRoutePojoTest.class);
- private int size = 200;
-
@Override
protected AbstractXmlApplicationContext createApplicationContext() {
return new
ClassPathXmlApplicationContext("org/apache/camel/component/jms/tuning/PerformanceRoutePojoTest-context.xml");
@@ -40,6 +38,7 @@ public class PerformanceRoutePojoTest extends
CamelSpringTestSupport {
public void testPojoPerformance() throws Exception {
long start = System.currentTimeMillis();
+ int size = 200;
getMockEndpoint("mock:audit").expectedMessageCount(size);
getMockEndpoint("mock:audit").expectsNoDuplicates().body();
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/tuning/PerformanceRouteTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/tuning/PerformanceRouteTest.java
index 30cc6b55348..6b15a2bc9ef 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/tuning/PerformanceRouteTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/tuning/PerformanceRouteTest.java
@@ -34,8 +34,6 @@ public class PerformanceRouteTest extends CamelTestSupport {
private static final Logger LOG =
LoggerFactory.getLogger(PerformanceRouteTest.class);
- private int size = 200;
-
@Test
public void testPerformance() throws Exception {
if (!canRunOnThisPlatform()) {
@@ -44,6 +42,7 @@ public class PerformanceRouteTest extends CamelTestSupport {
long start = System.currentTimeMillis();
+ int size = 200;
getMockEndpoint("mock:audit").expectedMessageCount(size);
getMockEndpoint("mock:audit").expectsNoDuplicates().body();
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/tx/ConditionalExceptionProcessor.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/tx/ConditionalExceptionProcessor.java
index b755c348c4a..b8630794f9d 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/tx/ConditionalExceptionProcessor.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/tx/ConditionalExceptionProcessor.java
@@ -28,7 +28,7 @@ public class ConditionalExceptionProcessor implements
Processor {
private static final Logger LOG =
LoggerFactory.getLogger(ConditionalExceptionProcessor.class);
private int count;
- private int maxCalls;
+ private final int maxCalls;
private String errorMsg;
public ConditionalExceptionProcessor() {
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/tx/JMSTransactionThrottlingRoutePolicyTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/tx/JMSTransactionThrottlingRoutePolicyTest.java
index d022c327567..23fc24ee6ff 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/tx/JMSTransactionThrottlingRoutePolicyTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/tx/JMSTransactionThrottlingRoutePolicyTest.java
@@ -26,8 +26,6 @@ import static
org.apache.camel.test.junit5.TestSupport.deleteDirectory;
public class JMSTransactionThrottlingRoutePolicyTest extends
CamelSpringTestSupport {
- private int size = 200;
-
@Override
protected ClassPathXmlApplicationContext createApplicationContext() {
return new ClassPathXmlApplicationContext(
@@ -44,6 +42,7 @@ public class JMSTransactionThrottlingRoutePolicyTest extends
CamelSpringTestSupp
@Test
public void testJmsTransactedThrottlingRoutePolicy() throws Exception {
MockEndpoint mock = getMockEndpoint("mock:result");
+ int size = 200;
mock.expectedMinimumMessageCount(size);
for (int i = 0; i < size; i++) {
