tadayosi commented on code in PR #3409: URL: https://github.com/apache/camel-k/pull/3409#discussion_r912752604
########## .github/workflows/generate.yml: ########## @@ -0,0 +1,69 @@ +# --------------------------------------------------------------------------- +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# --------------------------------------------------------------------------- + +name: generate + +on: + pull_request: + branches: + - main + - "release-*" + paths-ignore: + - 'docs/**' + - 'proposals/**' + - '**.adoc' + - '**.md' + - 'KEYS' + - 'LICENSE' + - 'NOTICE' + push: + branches: + - main + - "release-*" + paths-ignore: + - 'docs/**' + - 'proposals/**' + - '**.md' + - '**.adoc' + - 'KEYS' + - 'LICENSE' + - 'NOTICE' + +concurrency: + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }} + cancel-in-progress: true + +jobs: + generate: + strategy: + matrix: + # TODO: test an all the supported OS + # [ubuntu-20.04, macos-latest, windows-latest] + os: [ubuntu-20.04] + + runs-on: ${{ matrix.os }} + steps: + - name: Check out code + uses: actions/checkout@v2 + - name: Install Go + uses: actions/setup-go@v1 + with: + # make generate requires Go >=1.17 + go-version: 1.17.x Review Comment: Yes, but it just runs test with `make generate` and doesn't commit any changes to the repo, so it should be safe to go ahead to merge it. And after all `make generate` hasn't been working with Go 1.16.x so there's no reason to worry about backward compatibility on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
