tadayosi commented on code in PR #3432:
URL: https://github.com/apache/camel-k/pull/3432#discussion_r919634841
##########
.github/workflows/verify-generate.yml:
##########
@@ -59,11 +59,6 @@ jobs:
steps:
- name: Check out code
uses: actions/checkout@v2
- - name: Install Go
Review Comment:
Same here. I thought at least for `make generate` it's required to
explicitly install a go version in this workflow.
I thought the workflows which use `.github/actions/kamel-prepare-env` don't
need explicit go installation but those which don't use it still require it.
##########
script/Makefile:
##########
@@ -171,27 +172,27 @@ codegen:
gofmt -w pkg/util/defaults/defaults.go
-generate: generate-deepcopy generate-crd generate-client generate-doc
generate-keda generate-strimzi
-
-generate-client:
+generate: codegen-tools-install
Review Comment:
:+1:
##########
.github/workflows/validate.yml:
##########
@@ -37,10 +37,6 @@ jobs:
steps:
- name: Check out code
uses: actions/checkout@v2
- - name: Install Go
Review Comment:
I am a bit confused about this removal. Then is the version of go
preinstalled in the Ubuntu 20.04 runner used? Or the version depended from the
golangci-lint action?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
