Author: davsclaus
Date: Tue Apr 16 13:40:47 2013
New Revision: 1468410

URL: http://svn.apache.org/r1468410
Log:
Reduce logging noise in camel-bam

Modified:
    
camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/ActivityMonitorEngine.java
    
camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/BamProcessorSupport.java
    
camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/JpaBamProcessorSupport.java

Modified: 
camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/ActivityMonitorEngine.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/ActivityMonitorEngine.java?rev=1468410&r1=1468409&r2=1468410&view=diff
==============================================================================
--- 
camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/ActivityMonitorEngine.java
 (original)
+++ 
camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/ActivityMonitorEngine.java
 Tue Apr 16 13:40:47 2013
@@ -94,11 +94,11 @@ public class ActivityMonitorEngine exten
                     try {
                         Thread.sleep(timeToSleep);
                     } catch (InterruptedException e) {
-                        LOG.debug("Caught: " + e, e);
+                        // ignore
                     }
                 }
             } catch (Exception e) {
-                LOG.error("Caught: " + e, e);
+                LOG.warn("Error during running ActivityMonitorEngine. This 
exception is ignored.", e);
             }
         }
     }
@@ -110,9 +110,9 @@ public class ActivityMonitorEngine exten
             public Object doInJpa(EntityManager entityManager) throws 
PersistenceException {
                 // let's try locking the object first
                 if (isUseLocking()) {
-                    LOG.info("Attempting to lock: " + activityState);
+                    LOG.debug("Attempting to lock: {}", activityState);
                     entityManager.lock(activityState, LockModeType.WRITE);
-                    LOG.info("Grabbed lock: " + activityState);
+                    LOG.debug("Grabbed lock: {}", activityState);
                 }
 
                 try {

Modified: 
camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/BamProcessorSupport.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/BamProcessorSupport.java?rev=1468410&r1=1468409&r2=1468410&view=diff
==============================================================================
--- 
camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/BamProcessorSupport.java
 (original)
+++ 
camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/BamProcessorSupport.java
 Tue Apr 16 13:40:47 2013
@@ -82,7 +82,7 @@ public abstract class BamProcessorSuppor
                 try {
                     Thread.sleep(retrySleep);
                 } catch (InterruptedException e) {
-                    LOG.debug("Caught: " + e, e);
+                    // ignore
                 }
             }
             try {
@@ -104,11 +104,11 @@ public abstract class BamProcessorSuppor
                     }
                 });
                 if (i > 1) {
-                    LOG.info("Attempt {} worked!", i);
+                    LOG.debug("Attempt {} worked!", i);
                 }
                 return;
             } catch (Exception e) {
-                LOG.warn("Failed to complete transaction: " + e, e);
+                LOG.warn("Failed to complete transaction. This exception is 
ignored.", e);
             }
         }
     }
@@ -147,7 +147,7 @@ public abstract class BamProcessorSuppor
 
     protected void onError(TransactionStatus status, Exception e) throws 
RuntimeCamelException {
         status.setRollbackOnly();
-        LOG.error("Caught: " + e, e);
+        LOG.warn("Caught: " + e, e);
         throw wrapRuntimeCamelException(e);
     }
 

Modified: 
camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/JpaBamProcessorSupport.java
URL: 
http://svn.apache.org/viewvc/camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/JpaBamProcessorSupport.java?rev=1468410&r1=1468409&r2=1468410&view=diff
==============================================================================
--- 
camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/JpaBamProcessorSupport.java
 (original)
+++ 
camel/trunk/components/camel-bam/src/main/java/org/apache/camel/bam/processor/JpaBamProcessorSupport.java
 Tue Apr 16 13:40:47 2013
@@ -115,7 +115,7 @@ public class JpaBamProcessorSupport<T> e
     protected T loadEntity(Exchange exchange, Object key) throws Exception {
         LOCK.lock();
         try {
-            LOG.info(">> LoadEntity call");
+            LOG.trace("LoadEntity call");
             T entity = findEntityByCorrelationKey(key);
             if (entity == null) {
                 entity = createEntity(exchange, key);
@@ -127,7 +127,7 @@ public class JpaBamProcessorSupport<T> e
 
                 // Now we must flush to avoid concurrent updates clashing 
trying to
                 // insert the same row
-                LOG.debug("About to flush on entity: " + entity + " with key: 
" + key);
+                LOG.debug("About to flush on entity: {} with key: {}", entity, 
key);
                 template.flush();
             }
             return entity;
@@ -157,7 +157,7 @@ public class JpaBamProcessorSupport<T> e
             Method getter = 
IntrospectionSupport.getPropertyGetter(getEntityType(), getKeyPropertyName());
             return getter.getReturnType();
         } catch (NoSuchMethodException e) {
-            LOG.warn("no such getter for: " + getKeyPropertyName() + " on " + 
getEntityType() + ". Reason: " + e, e);
+            LOG.warn("no such getter for: " + getKeyPropertyName() + " on " + 
getEntityType() + ". This exception will be ignored.", e);
             return null;
         }
     }


Reply via email to