JiriOndrusek commented on PR #3919: URL: https://github.com/apache/camel-quarkus/pull/3919#issuecomment-1209220463
I looked into [DefaultCredenbtialProvider](https://github.com/googleapis/google-auth-library-java/blob/main/oauth2_http/java/com/google/auth/oauth2/DefaultCredentialsProvider.java) There are several ways of authentication for google clouds available, see the [documentation](https://cloud.google.com/docs/authentication#:~:text=You%20need%20to%20pass%20the,using%20the%20GOOGLE_APPLICATION_CREDENTIALS%20environment%20variable.). There is no limitation listed nor in [camel component doc](https://camel.apache.org/components/3.17.x/google-pubsub-component.html#_authentication_configuration) neither in [camel quarkus extension doc](https://camel.apache.org/camel-quarkus/2.9.x/reference/extensions/google-pubsub.html). - Scenario with disabled authentication is covered via emulated tests. - Basic scenario with `GoogleCredentials.getApplicationDefault()` using service account (via export of `GOOGLE_APPLICATION_CREDENTIALS`) is covered by using real account as is described in `RADME.adoc` file in the test module. Which brings me to several findings: 1. It is not possible to cover all scenarios via emulated tests or via tests with real account. (which uses `Accessing private data on behalf of a service account outside Google Cloud environments`) 2. I think, that we can put into documentation, that only several ways of authentications are supported in native mode -> service account, by exporting `GOOGLE_APPLICATION_CREDENTIALS` 3. Another option is to manually cover different authentication ways mainly for native mode. 4. Current coverage is acceptable and there is no need to add more sub-scenarios. I prefer option 2 - to list limitations for native mode. What do you think? @aldettinger @jamesnetherton @ppalaga -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
