tadayosi commented on code in PR #3589:
URL: https://github.com/apache/camel-k/pull/3589#discussion_r962591874
##########
pkg/cmd/log.go:
##########
@@ -46,6 +46,9 @@ func newCmdLog(rootCmdOptions *RootCmdOptions)
(*cobra.Command, *logCmdOptions)
RunE: options.run,
}
+ cmd.Flags().BoolP("tail", "f", false, "To show the end of the logs")
+ cmd.Flags().Int64P("tail-lines", "l", 10, "The number of lines from the
end of the logs to show")
Review Comment:
I noticed that `-f` shorthand generally means "follow" as in `kubectl logs
-f` and our `kamel log` has this behaviour. So `-f` may not be a good shorthand
character. `-t` is also not a good shorthand as it's already used in `kamel
run` as `--trait`. Maybe we should simply force `--tail`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
