squakez commented on code in PR #3631:
URL: https://github.com/apache/camel-k/pull/3631#discussion_r969396018
##########
pkg/cmd/install.go:
##########
@@ -108,16 +108,12 @@ func newCmdInstall(rootCmdOptions *RootCmdOptions)
(*cobra.Command, *installCmdO
cmd.Flags().String("operator-image-pull-policy", "", "Set the operator
ImagePullPolicy used for the operator deployment")
cmd.Flags().String("build-strategy", "", "Set the build strategy")
cmd.Flags().String("build-publish-strategy", "", "Set the build publish
strategy")
+ cmd.Flags().StringArray("build-publish-strategy-option", nil, "Add a
build publish strategy option, as <name=value>")
cmd.Flags().String("build-timeout", "", "Set how long the build process
can last")
cmd.Flags().String("trait-profile", "", "The profile to use for traits")
// Kaniko
- cmd.Flags().Bool("kaniko-build-cache", false, "To enable or disable the
Kaniko cache")
- cmd.Flags().String("kaniko-executor-image", "", "The docker image of
the Kaniko executor")
- cmd.Flags().String("kaniko-warmer-image", "", "The docker image of the
Kaniko warmer")
-
- // Buildah
- cmd.Flags().String("buildah-image", "", "The docker image to use for
Buildah")
Review Comment:
Cannot recall if this one was present in 1.10 release already. If so, we
should not remove but add a deprecation notice.
##########
pkg/cmd/install.go:
##########
@@ -171,47 +167,45 @@ func newCmdInstall(rootCmdOptions *RootCmdOptions)
(*cobra.Command, *installCmdO
type installCmdOptions struct {
*RootCmdOptions
- Wait bool `mapstructure:"wait"`
- BuildahImage string `mapstructure:"buildah-image"`
- ClusterSetupOnly bool `mapstructure:"cluster-setup"`
- SkipOperatorSetup bool `mapstructure:"skip-operator-setup"`
- SkipClusterSetup bool `mapstructure:"skip-cluster-setup"`
- SkipRegistrySetup bool `mapstructure:"skip-registry-setup"`
- SkipDefaultKameletsSetup bool
`mapstructure:"skip-default-kamelets-setup"`
- ExampleSetup bool `mapstructure:"example"`
- Global bool `mapstructure:"global"`
- KanikoBuildCache bool `mapstructure:"kaniko-build-cache"`
- KanikoExecutorImage string `mapstructure:"kaniko-executor-image"`
- KanikoWarmerImage string `mapstructure:"kaniko-warmer-image"`
- Save bool `mapstructure:"save" kamel:"omitsave"`
- Force bool `mapstructure:"force"`
- Olm bool `mapstructure:"olm"`
- ClusterType string `mapstructure:"cluster-type"`
- OutputFormat string `mapstructure:"output"`
- RuntimeVersion string `mapstructure:"runtime-version"`
- BaseImage string `mapstructure:"base-image"`
- OperatorID string `mapstructure:"operator-id"`
- OperatorImage string `mapstructure:"operator-image"`
- OperatorImagePullPolicy string
`mapstructure:"operator-image-pull-policy"`
- BuildStrategy string `mapstructure:"build-strategy"`
- BuildPublishStrategy string
`mapstructure:"build-publish-strategy"`
- BuildTimeout string `mapstructure:"build-timeout"`
- MavenExtensions []string `mapstructure:"maven-extensions"`
- MavenLocalRepository string
`mapstructure:"maven-local-repository"`
- MavenProperties []string `mapstructure:"maven-properties"`
- MavenRepositories []string `mapstructure:"maven-repositories"`
- MavenSettings string `mapstructure:"maven-settings"`
- MavenCASecret string `mapstructure:"maven-ca-secret"`
- MavenCLIOptions []string `mapstructure:"maven-cli-options"`
- HealthPort int32 `mapstructure:"health-port"`
- Monitoring bool `mapstructure:"monitoring"`
- MonitoringPort int32 `mapstructure:"monitoring-port"`
- TraitProfile string `mapstructure:"trait-profile"`
- Tolerations []string `mapstructure:"tolerations"`
- NodeSelectors []string `mapstructure:"node-selectors"`
- ResourcesRequirements []string `mapstructure:"operator-resources"`
- LogLevel string `mapstructure:"log-level"`
- EnvVars []string `mapstructure:"operator-env-vars"`
+ Wait bool `mapstructure:"wait"`
+ ClusterSetupOnly bool `mapstructure:"cluster-setup"`
+ SkipOperatorSetup bool
`mapstructure:"skip-operator-setup"`
+ SkipClusterSetup bool `mapstructure:"skip-cluster-setup"`
+ SkipRegistrySetup bool
`mapstructure:"skip-registry-setup"`
+ SkipDefaultKameletsSetup bool
`mapstructure:"skip-default-kamelets-setup"`
+ ExampleSetup bool `mapstructure:"example"`
+ Global bool `mapstructure:"global"`
+ KanikoBuildCache bool `mapstructure:"kaniko-build-cache"`
Review Comment:
Let's add a deprecation notice here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
