ppalaga commented on issue #1846:
URL: https://github.com/apache/camel-quarkus/issues/1846#issuecomment-1245928494
> Hmm, I tried caffeine version sync and got an error `Execution default-cli
of goal org.l2x6.cq:cq-maven-plugin:3.1.0:sync-versions failed:
java.lang.IllegalStateException: No such dependency
com.github.ben-manes.caffeine:jcache in
io.quarkus:quarkus-bom:2.12.0.Final:pom` - which makes sense, because it is not
there :) But `caffeine-version` property is inherited from camel.
Sorry, the sync should be
```
<caffeine.version></caffeine.version><!-- @sync
io.quarkus:quarkus-bom:${quarkus.version}
dep:com.github.ben-manes.caffeine:caffeine -->
```
We do not want to use the prop from Camel because it could get out of sync
from Quarkus.
> I didn't want to add caffeine dependency to the extension itself because
in theory it should work with any JSR107 implementation, not just caffeine.
That's right. Caffeine deps should be present only in the test module.
> `com.github.benmanes.caffeine.jcache.copy.JavaSerializationCopier` is
still needed;
I see. I'd say the most user friendly solution would be to create a new
extension `camel-quarkus-jcache-caffeine` that would host this reflection
registration plus it would depend on `quarkus-caffeine`. We should also add a
hint to `extensions/jcache/runtime/src/main/doc/usage.adoc` that end user may
want to depend on `camel-quarkus-jcache-caffeine` if the want to use caffeine
as a jcache impl.
> Removed explicit caching provider injection from the routes.
Great to hear that it works like that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]