tadayosi commented on code in PR #3674:
URL: https://github.com/apache/camel-k/pull/3674#discussion_r980810961


##########
e2e/namespace/install/cli/promote_test.go:
##########
@@ -107,6 +107,21 @@ func TestKamelCLIPromote(t *testing.T) {
                                Expect(IntegrationPodImage(nsProd, 
"promote-route")()).Should(Equal(IntegrationPodImage(nsDev, "promote-route")()))
                        })
 
+                       t.Run("plain integration promotion update", func(t 
*testing.T) {
+                               // Update the configmap
+                               var cmData = make(map[string]string)
+                               cmData["my-configmap-key"] = "I am production, 
but I was updated!"
+                               UpdatePlainTextConfigmap(nsProd, "my-cm", 
cmData)
+
+                               Expect(Kamel("promote", "-n", nsDev, 
"promote-route", "--to", nsProd).Execute()).To(Succeed())

Review Comment:
   So we don't introduce new flag e.g. `--continous` and just let promote 
always update the integration?  Is it safe in every case?  Shouldn't we at 
least show some warning message when it's going to overwrite it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to