ppalaga commented on code in PR #4187:
URL: https://github.com/apache/camel-quarkus/pull/4187#discussion_r997253319


##########
integration-test-groups/cxf-soap/cxf-soap-client/README.adoc:
##########
@@ -0,0 +1,28 @@
+= Quarkus CXF client tests
+
+These are pure client tests - i.e. there are intentionally no services 
implemented in the test application.
+All clients access services running in containers.
+
+== Maintenenance notes
+
+=== `CalculatorService.wsdl`
+
+`src/main/resources/wsdl/CalculatorService.wsdl` is a static copy of the WSDL 
served by the testing container.
+It would be too complicated to start the container before running the plugin, 
so we rather keep the static copy.
+
+There is `io.quarkiverse.cxf.client.it.CxfClientTest.wsdlUpToDate()` to ensure 
that it is up to date.

Review Comment:
   ```suggestion
   There is 
`org.apache.camel.quarkus.component.cxf.soap.it.CxfSoapClientTest.wsdlUpToDate()`
 to ensure that it is up to date.
   ```



##########
integration-test-groups/cxf-soap/cxf-soap-server/src/test/java/org/apache/camel/quarkus/component/cxf/soap/it/CxfSoapServiceTest.java:
##########
@@ -38,7 +38,7 @@ public void simpleSoapService() {
         final HelloPortType helloPort = service.getHelloPort();
         String endpointURL = getServerUrl() + "/soapservice/hello";
         ((BindingProvider) 
helloPort).getRequestContext().put(BindingProvider.ENDPOINT_ADDRESS_PROPERTY, 
endpointURL);
-        Assertions.assertThat(helloPort.hello("World")).isEqualTo("Hello World 
from CXF service");

Review Comment:
   We could have kept using assert-j it tends to have nicer error messages. Not 
worth bothering with it right now, let's keep it as you have it. 



##########
integration-test-groups/cxf-soap/cxf-soap-ws-security/README.adoc:
##########
@@ -0,0 +1,28 @@
+= Quarkus CXF client tests
+
+These are pure client tests - i.e. there are intentionally no services 
implemented in the test application.
+All clients access services running in containers.
+
+== Maintenenance notes
+
+=== `CalculatorService.wsdl`
+
+`src/main/resources/wsdl/WssCalculatorService.wsdl` is a static copy of the 
WSDL served by the testing container.
+It would be too complicated to start the container before running the plugin, 
so we rather keep the static copy.
+
+There is `io.quarkiverse.cxf.client.it.CxfClientTest.wsdlUpToDate()` to ensure 
that it is up to date.

Review Comment:
   ```suggestion
   There is 
`org.apache.camel.quarkus.component.cxf.soap.it.CxfSoapClientTest.wsdlUpToDate()`
 to ensure that it is up to date.
   ```



##########
integration-test-groups/cxf-soap/cxf-soap-ws-security/README.adoc:
##########
@@ -0,0 +1,28 @@
+= Quarkus CXF client tests

Review Comment:
   ```suggestion
   = Quarkus CXF WS-Security tests
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to