christophd commented on code in PR #1162:
URL: https://github.com/apache/camel-kamelets/pull/1162#discussion_r1032268560
##########
library/camel-kamelets-utils/pom.xml:
##########
@@ -71,12 +71,22 @@
<artifactId>camel-kafka</artifactId>
</dependency>
- <!-- AWS Dynamo DB camel component -->
+ <!-- Optional dependencies for data type conversion -->
<dependency>
<groupId>org.apache.camel</groupId>
<artifactId>camel-aws2-ddb</artifactId>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-aws2-s3</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-cloudevents</artifactId>
+ <!--<scope>provided</scope>-->
Review Comment:
It is used in AWS S3 CloudEvents output data type.
The thing is `camel-cloudevents` is not available in camel-quarkus. Because
of this the dependency is not able to resolve via CamelCatalog at runtime
because the catalog only knows camel-quarkus extensions. When adding it here as
a dependency it will be resolved as a transitive dependency using the Camel
core version.
We should add it to camel-quarkus and use scope provided here so Camel K is
able to resolve this dependency for bindings that actually use the data type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
