squakez commented on code in PR #4003:
URL: https://github.com/apache/camel-k/pull/4003#discussion_r1084935370
##########
e2e/namespace/upgrade/cli_upgrade_test.go:
##########
@@ -51,7 +51,7 @@ func TestOperatorUpgrade(t *testing.T) {
Expect(os.Setenv("KAMEL_BIN", kamel)).To(Succeed())
// Should both install the CRDs and kamel in the given namespace
- Expect(Kamel("install", "-n", ns, "--olm=false",
"--force").Execute()).To(Succeed())
+ Expect(Kamel("install", "-n", ns, "--olm=false", "--force",
"--base-image", defaults.BaseImage()).Execute()).To(Succeed())
Review Comment:
I think this is not required. As default, it already use that base image.
##########
e2e/namespace/upgrade/olm_upgrade_test.go:
##########
@@ -90,6 +90,7 @@ func TestOLMAutomaticUpgrade(t *testing.T) {
"--olm=true",
"--olm-source", catalogSourceName,
"--olm-source-namespace", ns,
+ "--base-image", defaults.BaseImage(),
Review Comment:
ditto
##########
e2e/namespace/upgrade/cli_upgrade_test.go:
##########
@@ -75,7 +75,7 @@ func TestOperatorUpgrade(t *testing.T) {
Expect(os.Setenv("KAMEL_BIN", "")).To(Succeed())
// Upgrade the operator by installing the current version
- Expect(KamelInstall(ns, "--olm=false", "--force",
"--operator-image", image).Execute()).To(Succeed())
+ Expect(KamelInstall(ns, "--olm=false", "--force",
"--operator-image", image, "--base-image",
defaults.BaseImage()).Execute()).To(Succeed())
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
