galderz commented on issue #4065: URL: https://github.com/apache/camel-quarkus/issues/4065#issuecomment-1403959117
@zhfeng Thanks a lot for building the reproducer. It worked for me. I also checked the proposed fix and it looks good to me but I'm in no way an expert in this area. Both `XSLTC.setClassName()` and `XSLTC.setPackageName()` depend on each other so at a first glance either could be called first, but in their current impl, if `setClassName` is called first, it wrongly sets the class name with the package name to the hardcoded default in XSLTC itself (`die.verwandlung`). You could then undo things when calling `setPackageName` but that would complicate things. Instead calling `XSLTC.setPackageName()` first makes things behave more naturally. You change the default to the set package and then you set the class name in `setClassName`. At this stage, you can do either of two things: you could first ask in the [`core-libs-dev` OpenJDK list](https://mail.openjdk.org/mailman/listinfo/core-libs-dev) or if you prefer you could go open a PR in [github.com/openjdk/jdk](http://github.com/openjdk/jdk). To open the PR you'll need OCA clearance. You can find information about OCA clearance and other topics in the [OpenJDK contributing guide](https://openjdk.org/guide/#contributing-to-an-openjdk-project). I would also recommend that you run the tier1 tests as well as the jaxp/xml tests (they are not part of tier1). You can run these extra tests via the `:jaxp_all` test group. See [Testing the JDK](https://openjdk.org/guide/#testing-the-jdk) for more details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
