oscerd commented on code in PR #9233:
URL: https://github.com/apache/camel/pull/9233#discussion_r1089250773
##########
components/camel-aws/camel-aws2-s3/src/main/java/org/apache/camel/component/aws2/s3/AWS2S3Producer.java:
##########
@@ -562,7 +562,13 @@ private void listObjects(S3Client s3Client, Exchange
exchange) throws InvalidPay
message.setBody(objectList.contents());
}
} else {
- ListObjectsResponse objectList =
s3Client.listObjects(ListObjectsRequest.builder().bucket(bucketName).build());
+ final ListObjectsRequest listObjectsRequest = ListObjectsRequest
+ .builder()
+ .bucket(bucketName)
+ .delimiter(getConfiguration().getDelimiter())
Review Comment:
> I did not checked if the delimiter and prefix are setted on the
configuration because it already is null on the ListObjectsRequest builder and
it will stay as null if is null on the configuration, but i can add the check
to avoid an unecessary operation on the builder.
>
Effectively we are not checking even on the consumer side, so I would
maintain the same behavior. So ignore my first review on that part.
> About the need of go also to main, should i do a cherry-pick?
Yes, it should be straightforward I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
