orpiske commented on code in PR #9295: URL: https://github.com/apache/camel/pull/9295#discussion_r1095936475
########## core/camel-xml-io/src/test/java/org/apache/camel/xml/out/ModelWriterTest.java: ########## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.xml.out; + +import java.io.*; Review Comment: This may fail the checkstyle check ########## core/camel-xml-io/src/main/java/org/apache/camel/xml/io/PrettyPrintXMLWriter.java: ########## @@ -0,0 +1,369 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.xml.io; + +import java.io.IOException; +import java.io.Writer; +import java.util.LinkedList; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +/** + * Implementation of XMLWriter which emits nicely formatted documents. + */ +public class PrettyPrintXMLWriter { + /** + * Line separator ("\n" on UNIX) + */ + protected static final String LS = System.getProperty("line.separator"); Review Comment: Minor thing, but `System.lineSeparator()` is a bit clearer ########## core/camel-xml-io/src/main/java/org/apache/camel/xml/io/PrettyPrintXMLWriter.java: ########## @@ -0,0 +1,369 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.xml.io; + +import java.io.IOException; +import java.io.Writer; +import java.util.LinkedList; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +/** + * Implementation of XMLWriter which emits nicely formatted documents. + */ +public class PrettyPrintXMLWriter { + /** + * Line separator ("\n" on UNIX) + */ + protected static final String LS = System.getProperty("line.separator"); + + private final Writer writer; + private final String lineIndenter; + private final String lineSeparator; + private final String encoding; + private final String docType; + private final LinkedList<String> elementStack = new LinkedList<>(); Review Comment: Maybe it would be better to use a List here, so to give more flexibility. ########## core/camel-xml-io/src/test/java/org/apache/camel/xml/out/ModelWriterTest.java: ########## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.xml.out; + +import java.io.*; +import java.lang.reflect.Field; +import java.lang.reflect.Method; +import java.lang.reflect.Modifier; +import java.nio.file.Files; +import java.nio.file.Paths; +import java.util.*; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.stream.Stream; + +import jakarta.xml.bind.annotation.XmlTransient; + +import org.apache.camel.model.RouteTemplatesDefinition; +import org.apache.camel.model.RoutesDefinition; +import org.apache.camel.model.TemplatedRoutesDefinition; +import org.apache.camel.model.rest.RestsDefinition; +import org.apache.camel.xml.in.ModelParser; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; + +import static org.junit.jupiter.api.AssertionFailureBuilder.assertionFailure; +import static org.junit.jupiter.api.Assertions.*; + +public class ModelWriterTest { + + public static final String NAMESPACE = "http://camel.apache.org/schema/spring";; + + @ParameterizedTest + @MethodSource("routes") + void testRoutes(String xml, String ns) throws Exception { + try (InputStream is = getClass().getClassLoader().getResourceAsStream(xml)) { + RoutesDefinition expected = new ModelParser(is, NAMESPACE).parseRoutesDefinition().get(); + StringWriter sw = new StringWriter(); + new ModelWriter(sw, ns).writeRoutesDefinition(expected); + RoutesDefinition actual = new ModelParser(new StringReader(sw.toString()), ns).parseRoutesDefinition().get(); + assertDeepEquals(expected, actual, sw.toString()); + } + } + + @ParameterizedTest + @MethodSource("rests") + void testRests(String xml, String ns) throws Exception { + try (InputStream is = getClass().getClassLoader().getResourceAsStream(xml)) { + RestsDefinition expected = new ModelParser(is, NAMESPACE).parseRestsDefinition().get(); + StringWriter sw = new StringWriter(); + new ModelWriter(sw, ns).writeRestsDefinition(expected); + RestsDefinition actual = new ModelParser(new StringReader(sw.toString()), ns).parseRestsDefinition().get(); + assertDeepEquals(expected, actual, sw.toString()); + } + } + + @ParameterizedTest + @MethodSource("routeTemplates") + void testRouteTemplates(String xml, String ns) throws Exception { + try (InputStream is = getClass().getClassLoader().getResourceAsStream(xml)) { + RouteTemplatesDefinition expected = new ModelParser(is, NAMESPACE).parseRouteTemplatesDefinition().get(); + StringWriter sw = new StringWriter(); + new ModelWriter(sw, ns).writeRouteTemplatesDefinition(expected); + RouteTemplatesDefinition actual + = new ModelParser(new StringReader(sw.toString()), ns).parseRouteTemplatesDefinition().get(); + assertDeepEquals(expected, actual, sw.toString()); + } + } + + @ParameterizedTest + @MethodSource("templatedRoutes") + void testTemplatedRoutes(String xml, String ns) throws Exception { + try (InputStream is = getClass().getClassLoader().getResourceAsStream(xml)) { + TemplatedRoutesDefinition expected = new ModelParser(is, NAMESPACE).parseTemplatedRoutesDefinition().get(); + StringWriter sw = new StringWriter(); + new ModelWriter(sw, ns).writeTemplatedRoutesDefinition(expected); + TemplatedRoutesDefinition actual + = new ModelParser(new StringReader(sw.toString()), ns).parseTemplatedRoutesDefinition().get(); + assertDeepEquals(expected, actual, sw.toString()); + } + } + + private static Stream<Arguments> routes() { + return definitions("routes"); + } + + private static Stream<Arguments> rests() { + return definitions("rests"); + } + + private static Stream<Arguments> routeTemplates() { + return definitions("routeTemplates"); + } + + private static Stream<Arguments> templatedRoutes() { + return definitions("templatedRoutes"); + } + + private static Stream<Arguments> definitions(String xml) { + try { + return Files.list(Paths.get("src/test/resources")) + .filter(p -> { + try { + return Files.isRegularFile(p) + && p.getFileName().toString().endsWith(".xml") + && Files.readString(p).contains("<" + xml); + } catch (IOException e) { + throw new IOError(e); + } + }) + .map(p -> p.getFileName().toString()) + .flatMap(p -> Stream.of(Arguments.of(p, ""), Arguments.of(p, NAMESPACE))); + } catch (IOException e) { + throw new IOError(e); + } + } + + private static void assertDeepEquals(Object expected, Object actual, String message) { + try { + try { + deepEquals(expected, actual, ""); + } catch (AssertionError e) { + assertionFailure() // + .cause(e) + .message(message) // + .expected(expected) // + .actual(actual) // + .buildAndThrow(); + } + } catch (IllegalAccessException e) { + assertionFailure().cause(e).buildAndThrow(); + } + } + + private static void deepEquals(Object expected, Object actual, String path) throws IllegalAccessException { + if (expected == null || actual == null) { + assertSame(expected, actual, path); + } else if (expected.getClass() != actual.getClass()) { + fail("Not equals at " + path); + } else if (expected instanceof Collection) { + Iterator<?> ie = ((Collection) expected).iterator(); + Iterator<?> ia = ((Collection) actual).iterator(); + int i = 0; + while (ie.hasNext() && ia.hasNext()) { + deepEquals(ie.next(), ia.next(), path + "[" + (i++) + "]"); + } + assertEquals(ie.hasNext(), ia.hasNext(), path); + } else if (expected.getClass() == AtomicBoolean.class) { + assertEquals(((AtomicBoolean) expected).get(), ((AtomicBoolean) actual).get(), path); + } else if (expected.getClass().isEnum()) { + assertEquals(((Enum) expected).name(), ((Enum) actual).name(), path); + } else if (expected.getClass().getName().startsWith("java.")) { + assertEquals(expected, actual, path); + } else { + for (Class<?> clazz = expected.getClass(); clazz != Object.class; clazz = clazz.getSuperclass()) { + for (Field field : clazz.getDeclaredFields()) { + if (isTransient(field)) { + continue; + } + field.setAccessible(true); + Object fe = field.get(expected); + Object fa = field.get(actual); + deepEquals(fe, fa, (path.length() > 0 ? path + "." : path) + field.getName()); + } + } + } + } + + private static Map<Field, Boolean> TRANSIENT = new ConcurrentHashMap<>(); + + private static boolean isTransient(Field field) { + return TRANSIENT.computeIfAbsent(field, ModelWriterTest::checkIsTransient); + } + + private static boolean checkIsTransient(Field field) { + if (Modifier.isStatic(field.getModifiers())) { + return true; + } + if (field.getAnnotation(XmlTransient.class) != null) { + return true; + } + String name = field.getName(); + try { + Method method = field.getDeclaringClass().getDeclaredMethod( + "get" + name.substring(0, 1).toUpperCase() + name.substring(1)); + if (method.getAnnotation(XmlTransient.class) != null) { + return true; + } + } catch (Throwable t) { + // ignore + } + try { + Method method = field.getDeclaringClass().getDeclaredMethod( + "set" + name.substring(0, 1).toUpperCase() + name.substring(1), + field.getType()); + if (method.getAnnotation(XmlTransient.class) != null) { + return true; + } + } catch (Throwable t) { Review Comment: Same note about catching `Throwable` ########## core/camel-xml-io/src/test/java/org/apache/camel/xml/out/ModelWriterTest.java: ########## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.xml.out; + +import java.io.*; +import java.lang.reflect.Field; +import java.lang.reflect.Method; +import java.lang.reflect.Modifier; +import java.nio.file.Files; +import java.nio.file.Paths; +import java.util.*; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.stream.Stream; + +import jakarta.xml.bind.annotation.XmlTransient; + +import org.apache.camel.model.RouteTemplatesDefinition; +import org.apache.camel.model.RoutesDefinition; +import org.apache.camel.model.TemplatedRoutesDefinition; +import org.apache.camel.model.rest.RestsDefinition; +import org.apache.camel.xml.in.ModelParser; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; + +import static org.junit.jupiter.api.AssertionFailureBuilder.assertionFailure; +import static org.junit.jupiter.api.Assertions.*; + +public class ModelWriterTest { + + public static final String NAMESPACE = "http://camel.apache.org/schema/spring";; + + @ParameterizedTest + @MethodSource("routes") + void testRoutes(String xml, String ns) throws Exception { + try (InputStream is = getClass().getClassLoader().getResourceAsStream(xml)) { + RoutesDefinition expected = new ModelParser(is, NAMESPACE).parseRoutesDefinition().get(); + StringWriter sw = new StringWriter(); + new ModelWriter(sw, ns).writeRoutesDefinition(expected); + RoutesDefinition actual = new ModelParser(new StringReader(sw.toString()), ns).parseRoutesDefinition().get(); + assertDeepEquals(expected, actual, sw.toString()); + } + } + + @ParameterizedTest + @MethodSource("rests") + void testRests(String xml, String ns) throws Exception { + try (InputStream is = getClass().getClassLoader().getResourceAsStream(xml)) { + RestsDefinition expected = new ModelParser(is, NAMESPACE).parseRestsDefinition().get(); + StringWriter sw = new StringWriter(); + new ModelWriter(sw, ns).writeRestsDefinition(expected); + RestsDefinition actual = new ModelParser(new StringReader(sw.toString()), ns).parseRestsDefinition().get(); + assertDeepEquals(expected, actual, sw.toString()); + } + } + + @ParameterizedTest + @MethodSource("routeTemplates") + void testRouteTemplates(String xml, String ns) throws Exception { + try (InputStream is = getClass().getClassLoader().getResourceAsStream(xml)) { + RouteTemplatesDefinition expected = new ModelParser(is, NAMESPACE).parseRouteTemplatesDefinition().get(); + StringWriter sw = new StringWriter(); + new ModelWriter(sw, ns).writeRouteTemplatesDefinition(expected); + RouteTemplatesDefinition actual + = new ModelParser(new StringReader(sw.toString()), ns).parseRouteTemplatesDefinition().get(); + assertDeepEquals(expected, actual, sw.toString()); + } + } + + @ParameterizedTest + @MethodSource("templatedRoutes") + void testTemplatedRoutes(String xml, String ns) throws Exception { + try (InputStream is = getClass().getClassLoader().getResourceAsStream(xml)) { + TemplatedRoutesDefinition expected = new ModelParser(is, NAMESPACE).parseTemplatedRoutesDefinition().get(); + StringWriter sw = new StringWriter(); + new ModelWriter(sw, ns).writeTemplatedRoutesDefinition(expected); + TemplatedRoutesDefinition actual + = new ModelParser(new StringReader(sw.toString()), ns).parseTemplatedRoutesDefinition().get(); + assertDeepEquals(expected, actual, sw.toString()); + } + } + + private static Stream<Arguments> routes() { + return definitions("routes"); + } + + private static Stream<Arguments> rests() { + return definitions("rests"); + } + + private static Stream<Arguments> routeTemplates() { + return definitions("routeTemplates"); + } + + private static Stream<Arguments> templatedRoutes() { + return definitions("templatedRoutes"); + } + + private static Stream<Arguments> definitions(String xml) { + try { + return Files.list(Paths.get("src/test/resources")) + .filter(p -> { + try { + return Files.isRegularFile(p) + && p.getFileName().toString().endsWith(".xml") + && Files.readString(p).contains("<" + xml); + } catch (IOException e) { + throw new IOError(e); + } + }) + .map(p -> p.getFileName().toString()) + .flatMap(p -> Stream.of(Arguments.of(p, ""), Arguments.of(p, NAMESPACE))); + } catch (IOException e) { + throw new IOError(e); + } + } + + private static void assertDeepEquals(Object expected, Object actual, String message) { + try { + try { + deepEquals(expected, actual, ""); + } catch (AssertionError e) { + assertionFailure() // + .cause(e) + .message(message) // + .expected(expected) // + .actual(actual) // + .buildAndThrow(); + } + } catch (IllegalAccessException e) { + assertionFailure().cause(e).buildAndThrow(); + } + } + + private static void deepEquals(Object expected, Object actual, String path) throws IllegalAccessException { + if (expected == null || actual == null) { + assertSame(expected, actual, path); + } else if (expected.getClass() != actual.getClass()) { + fail("Not equals at " + path); + } else if (expected instanceof Collection) { + Iterator<?> ie = ((Collection) expected).iterator(); + Iterator<?> ia = ((Collection) actual).iterator(); + int i = 0; + while (ie.hasNext() && ia.hasNext()) { + deepEquals(ie.next(), ia.next(), path + "[" + (i++) + "]"); + } + assertEquals(ie.hasNext(), ia.hasNext(), path); + } else if (expected.getClass() == AtomicBoolean.class) { + assertEquals(((AtomicBoolean) expected).get(), ((AtomicBoolean) actual).get(), path); + } else if (expected.getClass().isEnum()) { + assertEquals(((Enum) expected).name(), ((Enum) actual).name(), path); + } else if (expected.getClass().getName().startsWith("java.")) { + assertEquals(expected, actual, path); + } else { + for (Class<?> clazz = expected.getClass(); clazz != Object.class; clazz = clazz.getSuperclass()) { + for (Field field : clazz.getDeclaredFields()) { + if (isTransient(field)) { + continue; + } + field.setAccessible(true); + Object fe = field.get(expected); + Object fa = field.get(actual); + deepEquals(fe, fa, (path.length() > 0 ? path + "." : path) + field.getName()); + } + } + } + } + + private static Map<Field, Boolean> TRANSIENT = new ConcurrentHashMap<>(); + + private static boolean isTransient(Field field) { + return TRANSIENT.computeIfAbsent(field, ModelWriterTest::checkIsTransient); + } + + private static boolean checkIsTransient(Field field) { + if (Modifier.isStatic(field.getModifiers())) { + return true; + } + if (field.getAnnotation(XmlTransient.class) != null) { + return true; + } + String name = field.getName(); + try { + Method method = field.getDeclaringClass().getDeclaredMethod( + "get" + name.substring(0, 1).toUpperCase() + name.substring(1)); + if (method.getAnnotation(XmlTransient.class) != null) { + return true; + } + } catch (Throwable t) { + // ignore + } Review Comment: We should not catch `Throwable`. This would also catch JVM errors (such as OOME) and could hide some serious problems. In general, catching just Exception should be fine. ########## core/camel-xml-io/src/test/java/org/apache/camel/xml/out/ModelWriterTest.java: ########## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.xml.out; + +import java.io.*; +import java.lang.reflect.Field; +import java.lang.reflect.Method; +import java.lang.reflect.Modifier; +import java.nio.file.Files; +import java.nio.file.Paths; +import java.util.*; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.stream.Stream; + +import jakarta.xml.bind.annotation.XmlTransient; + +import org.apache.camel.model.RouteTemplatesDefinition; +import org.apache.camel.model.RoutesDefinition; +import org.apache.camel.model.TemplatedRoutesDefinition; +import org.apache.camel.model.rest.RestsDefinition; +import org.apache.camel.xml.in.ModelParser; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; + +import static org.junit.jupiter.api.AssertionFailureBuilder.assertionFailure; +import static org.junit.jupiter.api.Assertions.*; + +public class ModelWriterTest { + + public static final String NAMESPACE = "http://camel.apache.org/schema/spring";; + + @ParameterizedTest + @MethodSource("routes") + void testRoutes(String xml, String ns) throws Exception { + try (InputStream is = getClass().getClassLoader().getResourceAsStream(xml)) { + RoutesDefinition expected = new ModelParser(is, NAMESPACE).parseRoutesDefinition().get(); + StringWriter sw = new StringWriter(); + new ModelWriter(sw, ns).writeRoutesDefinition(expected); + RoutesDefinition actual = new ModelParser(new StringReader(sw.toString()), ns).parseRoutesDefinition().get(); + assertDeepEquals(expected, actual, sw.toString()); + } + } + + @ParameterizedTest + @MethodSource("rests") Review Comment: Same suggestion about `@Display` here and on the other tests. ########## core/camel-xml-io/src/test/java/org/apache/camel/xml/out/ModelWriterTest.java: ########## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.xml.out; + +import java.io.*; +import java.lang.reflect.Field; +import java.lang.reflect.Method; +import java.lang.reflect.Modifier; +import java.nio.file.Files; +import java.nio.file.Paths; +import java.util.*; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.stream.Stream; + +import jakarta.xml.bind.annotation.XmlTransient; + +import org.apache.camel.model.RouteTemplatesDefinition; +import org.apache.camel.model.RoutesDefinition; +import org.apache.camel.model.TemplatedRoutesDefinition; +import org.apache.camel.model.rest.RestsDefinition; +import org.apache.camel.xml.in.ModelParser; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; + +import static org.junit.jupiter.api.AssertionFailureBuilder.assertionFailure; +import static org.junit.jupiter.api.Assertions.*; + +public class ModelWriterTest { + + public static final String NAMESPACE = "http://camel.apache.org/schema/spring";; + + @ParameterizedTest + @MethodSource("routes") Review Comment: Given that this code is doing something complex, I think it would be good to annotate it with `@Display` describing the expectations (i.e.: `@Display("Tests that given an XML file containing X, will generate/process/something Y")`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
