orpiske commented on code in PR #9339:
URL: https://github.com/apache/camel/pull/9339#discussion_r1106197323
##########
components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/kinesis/consumer/KinesisDefaultResumeAdapter.java:
##########
@@ -46,8 +47,8 @@ public void setRequestBuilder(GetShardIteratorRequest.Builder
resumable) {
@Override
public void resume() {
- assert streamName != null;
- assert resumable != null;
Review Comment:
> And by Camel we additionally make a differentiation of about if that given
public method is a user-facing public code or not and then we apply the assert
approach or not depending on that?
Yes. But we don't have yet a way - other than documentation - to properly
convey this. I think we would need to use Java modules to do that. Sealed
classes may eventually help as well, but I don't think we've put these two
particular features in our radar yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
