squakez commented on code in PR #4021: URL: https://github.com/apache/camel-k/pull/4021#discussion_r1108572047
########## .github/workflows/native.yml: ########## @@ -0,0 +1,118 @@ +# --------------------------------------------------------------------------- +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# --------------------------------------------------------------------------- + +name: native + +env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + +on: + pull_request: + branches: + - main + - "release-*" + paths-ignore: + - 'docs/**' + - 'proposals/**' + - '**.adoc' + - '**.md' + - 'KEYS' + - 'LICENSE' + - 'NOTICE' + push: + branches: + - main + - "release-*" + paths-ignore: + - 'docs/**' + - 'proposals/**' + - '**.adoc' + - '**.md' + - 'KEYS' + - 'LICENSE' + - 'NOTICE' + workflow_dispatch: + inputs: + log-level: + description: 'Set the operator log level (info or debug)' + required: false + pre-built-kamel-image: + description: 'Kamel image url for skipping building of kamel stages. Used for debugging' + required: false + skip-problematic: + description: 'Whether tests marked as problematic should be skipped - false by default (sets CAMEL_K_TEST_SKIP_PROBLEMATIC)' + required: false + default: false + test-filters: + description: | + Filter the tests in this test suite by assigning the test pattern to TEST_NATIVE_RUN, + eg. TEST_NATIVE_RUN=TestBasic will only run tests prefixed with 'TestBasic' + required: false + +concurrency: + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }} + cancel-in-progress: true + +jobs: + install-native-high-memory: Review Comment: Why 2 different jobs? ########## .github/workflows/native.yml: ########## @@ -0,0 +1,118 @@ +# --------------------------------------------------------------------------- +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# --------------------------------------------------------------------------- + +name: native + +env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + +on: Review Comment: Once we have verified for this release, let's change this to run only on a nightly schedule to avoid such a high resource consumption process for every PR or merge. ########## .github/actions/kamel-config-cluster-kind/action.yml: ########## @@ -23,11 +23,12 @@ runs: steps: - id: install-cluster name: Install Cluster - uses: container-tools/kind-action@v1 + uses: container-tools/kind-action@61f1afd4807b0dac84f3232ec99e45c63701d220 Review Comment: We can merge with this commit id, but, please, create a follow up issue to release the kind-action and update here accordingly. ########## e2e/support/test_support.go: ########## @@ -93,10 +93,10 @@ const kubeConfigEnvVar = "KUBECONFIG" var TestTimeoutShort = 1 * time.Minute var TestTimeoutMedium = 5 * time.Minute -var TestTimeoutLong = 10 * time.Minute +var TestTimeoutLong = 15 * time.Minute // TestTimeoutVeryLong should be used only for testing native builds. -var TestTimeoutVeryLong = 90 * time.Minute +var TestTimeoutVeryLong = 60 * time.Minute Review Comment: We better provide a specific timeout for the native test, no needs to use global variables. With this change we are slowing down also any other test that would expect those previous values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
