fhossfel opened a new pull request, #9655:
URL: https://github.com/apache/camel/pull/9655
# Description
We are trying to access Pimcore through the camel-graphql component. It
requires that an API-Key ist either send as a Query-Parameter (by appending
"?apikey=123456" to the uri) or as a Header (".setHeader('x-api-key',
constant('123456'))").
At the moment neither approaches work because the additional parameter
triggers the following error:
There are 1 parameters that couldn't be set on the endpoint. Check the uri
if the parameters are spelt correctly and that they are properties of the
endpoint. Unknown parameters=[{apikey=123456} And the headers in the incoming
message are simply ignored.
This patch makes the component lenient. Any additional parameters are
passed as parameters to the GraphQL http uri.
I think the unit test could be implemented nicer. Would be thankful for
feedback on how to get the actual request string out of the Exchange. I think
that needs some changes to the GraphqlServer in the test classes. But adding
the additional query params to the message body as comments would violate the
JSON specification and copying all the headers from the Otto response to the
message might have unwanted side effects for the existing code base.
I habe not yet added the Exchange.HTTP_QUERY feature mentioned in the JIRA
ticket. I just want to keep things small and simple atm. I would rather a
second PR if that feature is actually wanted.
# Target
- [x] I checked that the commit is targeting the correct branch (note that
Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for
the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other
small items do not require a JIRA issue. In this case your pull request should
address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful
subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX]
Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the
appropriate JIRA issue.
-->
- [x] I formatted the code using `mvn -Pformat,fastinstall install && mvn
-Psourcecheck`
<!--
You can run the aforementioned command in your module so that the build
auto-formats your code and the source check verifies that is complies with our
coding style. This will also be verified as part of the checks and your PR may
be rejected if the checkstyle does not pass.
You can learn more about the contribution guidelines at
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
