gansheer commented on code in PR #4228:
URL: https://github.com/apache/camel-k/pull/4228#discussion_r1157396644
##########
pkg/util/jvm/keystore_test.go:
##########
@@ -29,15 +31,20 @@ func TestGenerateKeystore(t *testing.T) {
// No Data
var data [][]byte
ctx := context.Background()
- err := GenerateKeystore(ctx, "", "name", NewKeystorePassword(), data)
+ err := GenerateKeystore(ctx, "", "/tmp/keystore",
NewKeystorePassword(), data)
assert.Nil(t, err)
// Correct input
data = [][]byte{{0}, {1}}
- err = GenerateKeystore(ctx, "", "name", NewKeystorePassword(), data)
+ err = GenerateKeystore(ctx, "", "/tmp/keystore", NewKeystorePassword(),
data)
assert.NotNil(t, err)
Review Comment:
I know it is out if scope, but I am really confused about the fact that we
expect an error on something called "Correct input". It is not something that
needs to be fixed, merely an observation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
