davsclaus commented on PR #9939: URL: https://github.com/apache/camel/pull/9939#issuecomment-1527642821
Yeah we cannot have an automated test connects to some commercial company on the internet. The test needs to have its hostname / port etc externally configured and turned off by default. And ideally we should have wiremock tests with captured network communication so the test could run in isolation. Or if there are some docker images we can run via test-containers to run the test in isolation. So would it be possible for you to externalize that test case, eg make it read from src/test/resources/test-server.properties (or some similar name). And leave it with TODO insert server name here. And we can have that Mendelson mentioned in the properties file but turned off. Then end users can choose to turn that on and use it if they desire. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
