ppalaga commented on PR #4871: URL: https://github.com/apache/camel-quarkus/pull/4871#issuecomment-1535789390
Great work, @JiriOndrusek! I am totally happy that we can make this work also on CQ 2.13. I have a couple of questions/suggestions: 1. Could you please check what is the impact on the generated catalog in `catalog/target/classes/org/apache/camel/catalog/quarkus` after building the whole source tree before and after the change? Ideally, there should be no changes. Esp. snmp.json should still be there and the metadata in it should mirror the real state. 2. We should inform users in the docs that Camel Quarkus uses a different protocol implementation than plain Camel 3.18. Explain reasons, possible gotchas (if any) and explain that `org.snmp4j.snmp4j` will be used in Camel 4 and CQ 3 anyway. 3. Practical: Could please the code copied from Camel keep the original java source file structure, so that it is easier to compare what changes have been done between the two and so that it is easier to port any future changes from Camel 3.18? 4. Question: so now the SNMP tests in CQ 2.13.x and main are 100% identical, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
