This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new 2dbd2461cca (chores) camel-support: use final where possible/safe
2dbd2461cca is described below
commit 2dbd2461cca5be486178c1a57bd813634aaa1c47
Author: Otavio Rodolfo Piske <[email protected]>
AuthorDate: Thu May 11 16:52:29 2023 +0200
(chores) camel-support: use final where possible/safe
---
.../camel/support/DefaultScheduledPollConsumerScheduler.java | 2 +-
.../src/main/java/org/apache/camel/support/ExchangeHelper.java | 9 +++++----
.../main/java/org/apache/camel/support/builder/ValueBuilder.java | 2 +-
.../org/apache/camel/support/cache/DefaultConsumerCache.java | 2 +-
.../org/apache/camel/support/cache/DefaultProducerCache.java | 2 +-
.../main/java/org/apache/camel/support/cache/ServicePool.java | 4 ++--
.../org/apache/camel/support/processor/ThroughputLogger.java | 2 +-
.../main/java/org/apache/camel/support/task/ForegroundTask.java | 2 +-
8 files changed, 13 insertions(+), 12 deletions(-)
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/DefaultScheduledPollConsumerScheduler.java
b/core/camel-support/src/main/java/org/apache/camel/support/DefaultScheduledPollConsumerScheduler.java
index 4d640490a09..5ce5fc50547 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/DefaultScheduledPollConsumerScheduler.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/DefaultScheduledPollConsumerScheduler.java
@@ -45,7 +45,7 @@ public class DefaultScheduledPollConsumerScheduler extends
ServiceSupport implem
private Consumer consumer;
private ScheduledExecutorService scheduledExecutorService;
private boolean shutdownExecutor;
- private volatile List<ScheduledFuture<?>> futures = new ArrayList<>();
+ private final List<ScheduledFuture<?>> futures = new ArrayList<>();
private Runnable task;
private int poolSize = 1;
private int concurrentConsumers = 1;
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/ExchangeHelper.java
b/core/camel-support/src/main/java/org/apache/camel/support/ExchangeHelper.java
index 8906d58e5fa..876bf3750d5 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/ExchangeHelper.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/ExchangeHelper.java
@@ -60,8 +60,9 @@ import org.apache.camel.util.StringHelper;
*/
public final class ExchangeHelper {
- private static String defaultCharsetName =
ObjectHelper.getSystemProperty(Exchange.DEFAULT_CHARSET_PROPERTY, "UTF-8");
- private static Charset defaultCharset =
Charset.forName(defaultCharsetName);
+ private static final String DEFAULT_CHARSET_NAME
+ =
ObjectHelper.getSystemProperty(Exchange.DEFAULT_CHARSET_PROPERTY, "UTF-8");
+ private static final Charset DEFAULT_CHARSET =
Charset.forName(DEFAULT_CHARSET_NAME);
/**
* Utility classes should not have a public constructor.
@@ -959,11 +960,11 @@ public final class ExchangeHelper {
}
private static String getDefaultCharsetName() {
- return defaultCharsetName;
+ return DEFAULT_CHARSET_NAME;
}
private static Charset getDefaultCharset() {
- return defaultCharset;
+ return DEFAULT_CHARSET;
}
/**
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/builder/ValueBuilder.java
b/core/camel-support/src/main/java/org/apache/camel/support/builder/ValueBuilder.java
index c556c67d570..63687baefad 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/builder/ValueBuilder.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/builder/ValueBuilder.java
@@ -29,7 +29,7 @@ import org.apache.camel.Predicate;
* A builder of expressions or predicates based on values.
*/
public class ValueBuilder implements Expression, Predicate {
- private Expression expression;
+ private final Expression expression;
private boolean not;
public ValueBuilder(Expression expression) {
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/cache/DefaultConsumerCache.java
b/core/camel-support/src/main/java/org/apache/camel/support/cache/DefaultConsumerCache.java
index 0326c7148aa..d5644045f67 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/cache/DefaultConsumerCache.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/cache/DefaultConsumerCache.java
@@ -46,7 +46,7 @@ public class DefaultConsumerCache extends ServiceSupport
implements ConsumerCach
private EndpointUtilizationStatistics statistics;
private boolean extendedStatistics;
- private int maxCacheSize;
+ private final int maxCacheSize;
public DefaultConsumerCache(Object source, CamelContext camelContext, int
cacheSize) {
this.source = source;
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/cache/DefaultProducerCache.java
b/core/camel-support/src/main/java/org/apache/camel/support/cache/DefaultProducerCache.java
index 16d0a986aa7..6dcc4d3bd52 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/cache/DefaultProducerCache.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/cache/DefaultProducerCache.java
@@ -57,7 +57,7 @@ public class DefaultProducerCache extends ServiceSupport
implements ProducerCach
private EndpointUtilizationStatistics statistics;
private boolean eventNotifierEnabled = true;
private boolean extendedStatistics;
- private int maxCacheSize;
+ private final int maxCacheSize;
public DefaultProducerCache(Object source, CamelContext camelContext, int
cacheSize) {
this.source = source;
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/cache/ServicePool.java
b/core/camel-support/src/main/java/org/apache/camel/support/cache/ServicePool.java
index b3eaa82736d..7164a021bcb 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/cache/ServicePool.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/cache/ServicePool.java
@@ -55,8 +55,8 @@ abstract class ServicePool<S extends Service> extends
ServiceSupport implements
// keep track of all singleton endpoints with a pooled producer that are
evicted
// for multi pool then they have their own house-keeping for evictions
(more complex)
private final ConcurrentMap<Endpoint, Pool<S>> singlePoolEvicted = new
ConcurrentHashMap<>();
- private int capacity;
- private Map<S, S> cache;
+ private final int capacity;
+ private final Map<S, S> cache;
// synchronizes access only to cache
private final Object cacheLock;
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/processor/ThroughputLogger.java
b/core/camel-support/src/main/java/org/apache/camel/support/processor/ThroughputLogger.java
index 7b26a37e4d9..a72555c8bcd 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/processor/ThroughputLogger.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/processor/ThroughputLogger.java
@@ -54,7 +54,7 @@ public class ThroughputLogger extends AsyncProcessorSupport
implements AsyncProc
private String action = "Received";
private CamelContext camelContext;
private ScheduledExecutorService logSchedulerService;
- private CamelLogger logger;
+ private final CamelLogger logger;
private String lastLogMessage;
private double rate;
private double average;
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/task/ForegroundTask.java
b/core/camel-support/src/main/java/org/apache/camel/support/task/ForegroundTask.java
index a522d92d182..3ae4ca1c472 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/task/ForegroundTask.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/task/ForegroundTask.java
@@ -73,7 +73,7 @@ public class ForegroundTask implements BlockingTask {
private static final Logger LOG =
LoggerFactory.getLogger(ForegroundTask.class);
private final String name;
- private IterationBudget budget;
+ private final IterationBudget budget;
private Duration elapsed = Duration.ZERO;
ForegroundTask(IterationBudget budget, String name) {
