ppalaga opened a new issue, #4894:
URL: https://github.com/apache/camel-quarkus/issues/4894

   The test can currently be characterized as follows:
   
   1. The execution is moved to integration test phase 
   2. It relies on the existence of the runner artifact under target directory
   3. The path to the runner is passed from pom.xml to the test via property
   
   All of these are quite against how the tests in Quarkus Platform are set up:
   
   1. Native tests are not executed and thus their CI is only reaching Maven 
test phase. This was discussed several times and the general agreement was that 
this should change, but it has not changed yet. Hence point 1. may get solved 
at some point by the Platform team.
   2. Running `mvn package` in the generated test module directory 
`generated-platform-project/quarkus-camel/integration-tests/camel-quarkus-integration-test-groovy-dsl`
 does not produce any jars under target. Maybe quarkus-maven-plugin is not set 
up. It needs to be investigated.
   3. Setting the `quarkus.runner` property (and moving surefire to 
integration-test) can be done by this piece of XSL added to 
`src/main/resources/xslt/camel/test-pom.xsl` in the Platform source tree: 
   
   ```
       <!-- camel-quarkus-integration-test-groovy-dsl requires to move 
surefire:test to integration-test phase -->
       <!-- to be able to run java -jar target/*runner.jar from a test -->
       <xsl:template 
match="/pom:project/pom:build/pom:plugins/pom:plugin[(pom:artifactId/text() = 
'maven-surefire-plugin') and (/pom:project/pom:artifactId/text() = 
'camel-quarkus-integration-test-groovy-dsl')]">
           <xsl:copy>
               <xsl:apply-templates select="@* | node()" />
               <executions>
                   <execution>
                       <id>default-test</id>
                       <goals>
                           <goal>test</goal>
                       </goals>
                       <phase>integration-test</phase>
                       <configuration>
                           <systemProperties>
                               
<quarkus.runner>&#36;{project.build.directory}/quarkus-app/quarkus-run.jar</quarkus.runner>
                           </systemProperties>
                       </configuration>
                   </execution>
               </executions>
           </xsl:copy>
       </xsl:template>
   ```
   
   Instead on pushing on any of the above, I'll remove 
camel-quarkus-integration-test-groovy-dsl from the test list we publish for the 
platform for now.
   
   @essobedo I wonder whether the classloading issue because of which we have 
this special setup cannot be fixed in Quarkus or elsewhere? If it can be fixed, 
we would not need to bother with any special measures to make the test work in 
the Platform.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to