essobedo commented on code in PR #10325:
URL: https://github.com/apache/camel/pull/10325#discussion_r1225507881
##########
components/camel-spring-rabbitmq/src/main/java/org/apache/camel/component/springrabbit/DefaultMessagePropertiesConverter.java:
##########
@@ -39,9 +40,64 @@ public DefaultMessagePropertiesConverter(CamelContext
camelContext, HeaderFilter
@Override
public MessageProperties toMessageProperties(Exchange exchange) {
MessageProperties answer = new MessageProperties();
- String contentType = ExchangeHelper.getContentType(exchange);
+
+ Object deliveryMode =
exchange.getMessage().removeHeader(SpringRabbitMQConstants.DELIVERY_MODE);
+ if (deliveryMode != null) {
+ answer.setDeliveryMode(deliveryMode instanceof MessageDeliveryMode
? (MessageDeliveryMode) deliveryMode
+ :
MessageDeliveryMode.fromInt(Integer.parseInt(deliveryMode.toString())));
+ }
+ Object type =
exchange.getMessage().removeHeader(SpringRabbitMQConstants.TYPE);
Review Comment:
What I can tell for sure is that it is quite unexpected that a converter
alters the message. If they need to be removed it should be definitively done
elsewhere IMHO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
