This is an automated email from the ASF dual-hosted git repository. orpiske pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git
commit cb8d36c14b8d2c2908259b829be4ef22790ecd54 Author: Otavio Rodolfo Piske <[email protected]> AuthorDate: Mon Jun 12 11:54:33 2023 +0200 (chores) camel-base-engine: use final when possible --- .../org/apache/camel/impl/engine/BaseExecutorServiceManager.java | 2 +- .../java/org/apache/camel/impl/engine/DefaultNodeIdFactory.java | 6 +++--- .../src/main/java/org/apache/camel/impl/engine/ValidatorKey.java | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/BaseExecutorServiceManager.java b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/BaseExecutorServiceManager.java index e724891bf7b..83f786db44f 100644 --- a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/BaseExecutorServiceManager.java +++ b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/BaseExecutorServiceManager.java @@ -67,7 +67,7 @@ public class BaseExecutorServiceManager extends ServiceSupport implements Execut private String threadNamePattern; private long shutdownAwaitTermination = 10000; private String defaultThreadPoolProfileId = "defaultThreadPoolProfile"; - private ThreadPoolProfile defaultProfile; + private final ThreadPoolProfile defaultProfile; public BaseExecutorServiceManager(CamelContext camelContext) { this.camelContext = camelContext; diff --git a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultNodeIdFactory.java b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultNodeIdFactory.java index a4b486bf851..cd92266dc07 100644 --- a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultNodeIdFactory.java +++ b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultNodeIdFactory.java @@ -28,7 +28,7 @@ import org.apache.camel.spi.NodeIdFactory; */ public class DefaultNodeIdFactory implements NodeIdFactory { - protected static Map<String, AtomicInteger> nodeCounters = new ConcurrentHashMap<>(); + protected static final Map<String, AtomicInteger> NODE_COUNTERS = new ConcurrentHashMap<>(); @Override public String createId(NamedNode definition) { @@ -40,7 +40,7 @@ public class DefaultNodeIdFactory implements NodeIdFactory { * Returns the counter for the given node key, lazily creating one if necessary */ protected static AtomicInteger getNodeCounter(String key) { - return nodeCounters.computeIfAbsent(key, k -> new AtomicInteger()); + return NODE_COUNTERS.computeIfAbsent(key, k -> new AtomicInteger()); } /** @@ -48,7 +48,7 @@ public class DefaultNodeIdFactory implements NodeIdFactory { * accidentally) */ protected static void resetAllCounters() { - for (AtomicInteger counter : nodeCounters.values()) { + for (AtomicInteger counter : NODE_COUNTERS.values()) { counter.set(0); } } diff --git a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/ValidatorKey.java b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/ValidatorKey.java index 1c8a111c8dd..fb1bfe85adc 100644 --- a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/ValidatorKey.java +++ b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/ValidatorKey.java @@ -25,7 +25,7 @@ import org.apache.camel.spi.DataType; */ public final class ValidatorKey extends ValueHolder<String> { - private DataType type; + private final DataType type; public ValidatorKey(DataType type) { super(type.toString());
