This is an automated email from the ASF dual-hosted git repository. orpiske pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git
commit cd97abde277deee1248d2ee2973f951c1f425964 Author: Otavio R. Piske <[email protected]> AuthorDate: Sat Jul 8 20:21:52 2023 +0200 (chores) camel-core-processor: use final when possible --- .../org/apache/camel/processor/FatalFallbackErrorHandler.java | 2 +- .../java/org/apache/camel/processor/RecipientListProcessor.java | 2 +- .../src/main/java/org/apache/camel/processor/Resequencer.java | 8 ++++---- .../main/java/org/apache/camel/processor/SamplingThrottler.java | 4 ++-- .../main/java/org/apache/camel/processor/ThreadsProcessor.java | 2 +- .../main/java/org/apache/camel/processor/WireTapProcessor.java | 2 +- .../camel/processor/loadbalancer/RoundRobinLoadBalancer.java | 2 +- .../apache/camel/processor/loadbalancer/StickyLoadBalancer.java | 4 ++-- .../main/java/org/apache/camel/processor/resequencer/Element.java | 2 +- .../org/apache/camel/processor/resequencer/ResequencerEngine.java | 2 +- .../apache/camel/processor/resume/TransientResumeStrategy.java | 2 +- 11 files changed, 16 insertions(+), 16 deletions(-) diff --git a/core/camel-core-processor/src/main/java/org/apache/camel/processor/FatalFallbackErrorHandler.java b/core/camel-core-processor/src/main/java/org/apache/camel/processor/FatalFallbackErrorHandler.java index 68a455e4530..e7c340109fc 100644 --- a/core/camel-core-processor/src/main/java/org/apache/camel/processor/FatalFallbackErrorHandler.java +++ b/core/camel-core-processor/src/main/java/org/apache/camel/processor/FatalFallbackErrorHandler.java @@ -42,7 +42,7 @@ public class FatalFallbackErrorHandler extends DelegateAsyncProcessor implements private static final Logger LOG = LoggerFactory.getLogger(FatalFallbackErrorHandler.class); - private boolean deadLetterChannel; + private final boolean deadLetterChannel; public FatalFallbackErrorHandler(Processor processor) { this(processor, false); diff --git a/core/camel-core-processor/src/main/java/org/apache/camel/processor/RecipientListProcessor.java b/core/camel-core-processor/src/main/java/org/apache/camel/processor/RecipientListProcessor.java index d3f242f6279..109e78fcf72 100644 --- a/core/camel-core-processor/src/main/java/org/apache/camel/processor/RecipientListProcessor.java +++ b/core/camel-core-processor/src/main/java/org/apache/camel/processor/RecipientListProcessor.java @@ -81,7 +81,7 @@ public class RecipientListProcessor extends MulticastProcessor { private final int index; private final Endpoint endpoint; private final AsyncProducer producer; - private Processor prepared; + private final Processor prepared; private final Exchange exchange; private final ProducerCache producerCache; private final ExchangePattern pattern; diff --git a/core/camel-core-processor/src/main/java/org/apache/camel/processor/Resequencer.java b/core/camel-core-processor/src/main/java/org/apache/camel/processor/Resequencer.java index 1c2db9b6ca1..0bcf9e215ad 100644 --- a/core/camel-core-processor/src/main/java/org/apache/camel/processor/Resequencer.java +++ b/core/camel-core-processor/src/main/java/org/apache/camel/processor/Resequencer.java @@ -78,7 +78,7 @@ public class Resequencer extends AsyncProcessorSupport implements Navigate<Proce private boolean reverse; private boolean allowDuplicates; private Predicate completionPredicate; - private Expression expression; + private final Expression expression; private final CamelContext camelContext; private final AsyncProcessor processor; @@ -405,11 +405,11 @@ public class Resequencer extends AsyncProcessorSupport implements Navigate<Proce */ private class BatchSender extends Thread { - private Queue<Exchange> queue; - private Lock queueLock = new ReentrantLock(); + private final Queue<Exchange> queue; + private final Lock queueLock = new ReentrantLock(); private final AtomicBoolean exchangeEnqueued = new AtomicBoolean(); private final Queue<String> completionPredicateMatched = new ConcurrentLinkedQueue<>(); - private Condition exchangeEnqueuedCondition = queueLock.newCondition(); + private final Condition exchangeEnqueuedCondition = queueLock.newCondition(); BatchSender() { super(camelContext.getExecutorServiceManager().resolveThreadName("Batch Sender")); diff --git a/core/camel-core-processor/src/main/java/org/apache/camel/processor/SamplingThrottler.java b/core/camel-core-processor/src/main/java/org/apache/camel/processor/SamplingThrottler.java index 560712d0a53..e0c9d647c82 100644 --- a/core/camel-core-processor/src/main/java/org/apache/camel/processor/SamplingThrottler.java +++ b/core/camel-core-processor/src/main/java/org/apache/camel/processor/SamplingThrottler.java @@ -49,9 +49,9 @@ public class SamplingThrottler extends AsyncProcessorSupport implements Traceabl private long periodInMillis; private TimeUnit units; private long timeOfLastExchange; - private StopProcessor stopper = new StopProcessor(); + private final StopProcessor stopper = new StopProcessor(); private final Object calculationLock = new Object(); - private SampleStats sampled = new SampleStats(); + private final SampleStats sampled = new SampleStats(); public SamplingThrottler(long messageFrequency) { if (messageFrequency <= 0) { diff --git a/core/camel-core-processor/src/main/java/org/apache/camel/processor/ThreadsProcessor.java b/core/camel-core-processor/src/main/java/org/apache/camel/processor/ThreadsProcessor.java index ecfc7d9d6d1..072fcbbef18 100644 --- a/core/camel-core-processor/src/main/java/org/apache/camel/processor/ThreadsProcessor.java +++ b/core/camel-core-processor/src/main/java/org/apache/camel/processor/ThreadsProcessor.java @@ -59,7 +59,7 @@ public class ThreadsProcessor extends AsyncProcessorSupport implements IdAware, private final CamelContext camelContext; private final ExecutorService executorService; private final ThreadPoolRejectedPolicy rejectedPolicy; - private volatile boolean shutdownExecutorService; + private final boolean shutdownExecutorService; private final AtomicBoolean shutdown = new AtomicBoolean(true); private final class ProcessCall implements Runnable, Rejectable { diff --git a/core/camel-core-processor/src/main/java/org/apache/camel/processor/WireTapProcessor.java b/core/camel-core-processor/src/main/java/org/apache/camel/processor/WireTapProcessor.java index 151f3dd1275..6462cff7845 100644 --- a/core/camel-core-processor/src/main/java/org/apache/camel/processor/WireTapProcessor.java +++ b/core/camel-core-processor/src/main/java/org/apache/camel/processor/WireTapProcessor.java @@ -64,7 +64,7 @@ public class WireTapProcessor extends AsyncProcessorSupport private final ExchangePattern exchangePattern; private final boolean copy; private final ExecutorService executorService; - private volatile boolean shutdownExecutorService; + private final boolean shutdownExecutorService; private final LongAdder taskCount = new LongAdder(); private ProcessorExchangeFactory processorExchangeFactory; private PooledExchangeTaskFactory taskFactory; diff --git a/core/camel-core-processor/src/main/java/org/apache/camel/processor/loadbalancer/RoundRobinLoadBalancer.java b/core/camel-core-processor/src/main/java/org/apache/camel/processor/loadbalancer/RoundRobinLoadBalancer.java index 6a66fd0934c..bd421985902 100644 --- a/core/camel-core-processor/src/main/java/org/apache/camel/processor/loadbalancer/RoundRobinLoadBalancer.java +++ b/core/camel-core-processor/src/main/java/org/apache/camel/processor/loadbalancer/RoundRobinLoadBalancer.java @@ -25,7 +25,7 @@ import org.apache.camel.Exchange; * Implements the round robin load balancing policy */ public class RoundRobinLoadBalancer extends QueueLoadBalancer { - private AtomicInteger counter = new AtomicInteger(-1); + private final AtomicInteger counter = new AtomicInteger(-1); @Override protected AsyncProcessor chooseProcessor(AsyncProcessor[] processors, Exchange exchange) { diff --git a/core/camel-core-processor/src/main/java/org/apache/camel/processor/loadbalancer/StickyLoadBalancer.java b/core/camel-core-processor/src/main/java/org/apache/camel/processor/loadbalancer/StickyLoadBalancer.java index 307b32c73c5..9070fb70269 100644 --- a/core/camel-core-processor/src/main/java/org/apache/camel/processor/loadbalancer/StickyLoadBalancer.java +++ b/core/camel-core-processor/src/main/java/org/apache/camel/processor/loadbalancer/StickyLoadBalancer.java @@ -28,8 +28,8 @@ import org.apache.camel.Expression; * load balancing; rather like jsessionid in the web or JMSXGroupID in JMS. */ public class StickyLoadBalancer extends QueueLoadBalancer { - private Expression correlationExpression; - private RoundRobinLoadBalancer loadBalancer; + private final Expression correlationExpression; + private final RoundRobinLoadBalancer loadBalancer; private int numberOfHashGroups = 64 * 1024; private final Map<Object, AsyncProcessor> stickyMap = new ConcurrentHashMap<>(); diff --git a/core/camel-core-processor/src/main/java/org/apache/camel/processor/resequencer/Element.java b/core/camel-core-processor/src/main/java/org/apache/camel/processor/resequencer/Element.java index 7d9127f33f7..e5d43229ac5 100644 --- a/core/camel-core-processor/src/main/java/org/apache/camel/processor/resequencer/Element.java +++ b/core/camel-core-processor/src/main/java/org/apache/camel/processor/resequencer/Element.java @@ -25,7 +25,7 @@ class Element<E> implements TimeoutHandler { /** * The contained object. */ - private E object; + private final E object; /** * Not <code>null</code> if this element is currently beeing scheduled for timing out. diff --git a/core/camel-core-processor/src/main/java/org/apache/camel/processor/resequencer/ResequencerEngine.java b/core/camel-core-processor/src/main/java/org/apache/camel/processor/resequencer/ResequencerEngine.java index e0578587b82..2a3fd4b24ad 100644 --- a/core/camel-core-processor/src/main/java/org/apache/camel/processor/resequencer/ResequencerEngine.java +++ b/core/camel-core-processor/src/main/java/org/apache/camel/processor/resequencer/ResequencerEngine.java @@ -60,7 +60,7 @@ public class ResequencerEngine<E> { /** * A sequence of elements for sorting purposes. */ - private Sequence<Element<E>> sequence; + private final Sequence<Element<E>> sequence; /** * A timer for scheduling timeout notifications. diff --git a/core/camel-core-processor/src/main/java/org/apache/camel/processor/resume/TransientResumeStrategy.java b/core/camel-core-processor/src/main/java/org/apache/camel/processor/resume/TransientResumeStrategy.java index 89ca17daf87..ca35a1757b3 100644 --- a/core/camel-core-processor/src/main/java/org/apache/camel/processor/resume/TransientResumeStrategy.java +++ b/core/camel-core-processor/src/main/java/org/apache/camel/processor/resume/TransientResumeStrategy.java @@ -133,7 +133,7 @@ public class TransientResumeStrategy implements ResumeStrategy { public static ResumeCache<Object> createSimpleCache() { return new ResumeCache<>() { - private Map<Object, Object> cache = new HashMap<>(); + private final Map<Object, Object> cache = new HashMap<>(); @Override public Object computeIfAbsent(Object key, Function<? super Object, ? super Object> mapping) {
