squakez commented on code in PR #4649:
URL: https://github.com/apache/camel-k/pull/4649#discussion_r1285474794
##########
pkg/trait/builder.go:
##########
@@ -78,17 +80,34 @@ func (t *builderTrait) Apply(e *Environment) error {
}
return nil
}
- e.Pipeline = append(e.Pipeline, v1.Task{Builder: builderTask})
+
+ pipelineTasks = append(pipelineTasks, v1.Task{Builder: builderTask})
// Custom tasks
if t.Tasks != nil {
- e.Pipeline = append(e.Pipeline, t.customTasks()...)
+ if len(t.Tasks) > 0 &&
e.Platform.Status.Build.BuildConfiguration.Strategy != v1.BuildStrategyPod {
+
t.L.Info(string(e.Platform.Status.Build.BuildConfiguration.Strategy))
+ t.L.Info(string(v1.BuildStrategyPod))
+ e.IntegrationKit.Status.Phase =
v1.IntegrationKitPhaseError
+
e.IntegrationKit.Status.SetCondition("IntegrationKitTasksValid",
+ corev1.ConditionFalse,
+ "IntegrationKitTasksValid",
+ fmt.Sprintf("User customizable task unavailable
when using `%s` platform build strategy: use `%s` instead.",
Review Comment:
```suggestion
fmt.Sprintf("Pipeline tasks unavailable when
using `%s` platform build strategy: use `%s` instead.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
