christophd commented on code in PR #1566: URL: https://github.com/apache/camel-kamelets/pull/1566#discussion_r1315441192
########## .github/workflows/yaks-tests.yaml: ########## @@ -42,7 +42,7 @@ concurrency: env: YAKS_VERSION: 0.16.0 - YAKS_RUN_OPTIONS: "--timeout=15m --local -e YAKS_CAMELK_MAX_ATTEMPTS=10 -e YAKS_JBANG_CAMEL_VERSION=4.0.0 -e YAKS_JBANG_KAMELETS_VERSION=4.0.0-SNAPSHOT -e YAKS_JBANG_KAMELETS_LOCAL_DIR=../../../kamelets -e YAKS_KAMELET_API_VERSION=v1alpha1" + YAKS_RUN_OPTIONS: "--timeout=15m --local -e YAKS_CAMELK_MAX_ATTEMPTS=10 -e YAKS_JBANG_CAMEL_VERSION=4.0.0 -e YAKS_JBANG_KAMELETS_VERSION=4.0.0 -e YAKS_JBANG_KAMELETS_LOCAL_DIR=../../../kamelets" Review Comment: I have had a look into the failing YAKS tests and I think `-e YAKS_JBANG_KAMELETS_VERSION=4.0.0` is a problem because the v4.0.0 has not been released yet. I can see this in the logs when Camel JBang starts the route: ``` [jbang] Resolving dependencies... [jbang] org.apache.camel:camel-bom:4.0.0@pom [jbang] org.apache.camel:camel-jbang-core:4.0.0 [jbang] org.apache.camel.kamelets:camel-kamelets:4.0.0 [jbang] [ERROR] Could not resolve dependencies: Could not find artifact org.apache.camel.kamelets:camel-kamelets:jar:4.0.0 in central (https://repo1.maven.org/maven2) ``` ########## .github/workflows/yaks-tests.yaml: ########## @@ -42,7 +42,7 @@ concurrency: env: YAKS_VERSION: 0.16.0 - YAKS_RUN_OPTIONS: "--timeout=15m --local -e YAKS_CAMELK_MAX_ATTEMPTS=10 -e YAKS_JBANG_CAMEL_VERSION=4.0.0 -e YAKS_JBANG_KAMELETS_VERSION=4.0.0-SNAPSHOT -e YAKS_JBANG_KAMELETS_LOCAL_DIR=../../../kamelets -e YAKS_KAMELET_API_VERSION=v1alpha1" Review Comment: Question regarding `-e YAKS_KAMELET_API_VERSION=v1alpha1` Is Camel 4.0.0 able to handle Pipe resources? Last time I checked this raised me some errors because Pipe has not been recognized by Camel JBang ########## .github/workflows/yaks-tests.yaml: ########## @@ -42,7 +42,7 @@ concurrency: env: YAKS_VERSION: 0.16.0 - YAKS_RUN_OPTIONS: "--timeout=15m --local -e YAKS_CAMELK_MAX_ATTEMPTS=10 -e YAKS_JBANG_CAMEL_VERSION=4.0.0 -e YAKS_JBANG_KAMELETS_VERSION=4.0.0-SNAPSHOT -e YAKS_JBANG_KAMELETS_LOCAL_DIR=../../../kamelets -e YAKS_KAMELET_API_VERSION=v1alpha1" + YAKS_RUN_OPTIONS: "--timeout=15m --local -e YAKS_CAMELK_MAX_ATTEMPTS=10 -e YAKS_JBANG_CAMEL_VERSION=4.0.0 -e YAKS_JBANG_KAMELETS_VERSION=4.0.0 -e YAKS_JBANG_KAMELETS_LOCAL_DIR=../../../kamelets" Review Comment: Can we keep using `4.0.0-SNAPSHOT` here and bump to 4.0.0 once released? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
