marcingrzejszczak commented on code in PR #11381:
URL: https://github.com/apache/camel/pull/11381#discussion_r1325566521
##########
components/camel-observation/src/main/java/org/apache/camel/observation/MicrometerObservationSpanAdapter.java:
##########
@@ -80,11 +81,13 @@ public void setTag(String key, Boolean value) {
@Override
public void setLowCardinalityTag(Tag key, String value) {
observation.lowCardinalityKeyValue(key.toString(), value);
Review Comment:
Do we want to deprecate this? If we want to migrate to the attributes
version we could deprecate all of the `key.toString()` options and mark that
this is scheduled for removal in e.g. 3 minor releases? WDYT?
##########
components/camel-tracing/src/main/java/org/apache/camel/tracing/Tag.java:
##########
@@ -17,13 +17,39 @@
package org.apache.camel.tracing;
public enum Tag {
- COMPONENT,
- HTTP_STATUS,
- HTTP_METHOD,
- HTTP_URL,
- MESSAGE_BUS_DESTINATION,
- DB_TYPE,
- DB_INSTANCE,
- DB_STATEMENT,
- ERROR
+ COMPONENT("component"),
Review Comment:
This looks great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
