davsclaus commented on code in PR #11354:
URL: https://github.com/apache/camel/pull/11354#discussion_r1328627336
##########
components/camel-tracing/src/main/java/org/apache/camel/tracing/SpanAdapter.java:
##########
@@ -23,24 +23,12 @@ public interface SpanAdapter {
void setError(boolean error);
- void setTag(Tag key, String value);
-
- void setTag(Tag key, Number value);
-
void setTag(String key, String value);
void setTag(String key, Number value);
void setTag(String key, Boolean value);
- default void setLowCardinalityTag(Tag key, String value) {
Review Comment:
Yeah Camel end users dont really work directly with this API. And we have
migration docs where we can write the steps people need to migrate. And its
better to get ahead of this early in Camel v4 than later.
##########
components/camel-tracing/src/main/java/org/apache/camel/tracing/SpanAdapter.java:
##########
@@ -23,24 +23,12 @@ public interface SpanAdapter {
void setError(boolean error);
- void setTag(Tag key, String value);
Review Comment:
See next comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
