squakez commented on code in PR #4805:
URL: https://github.com/apache/camel-k/pull/4805#discussion_r1348331747
##########
pkg/util/jib/configuration.go:
##########
@@ -50,8 +53,8 @@ type JibProfile struct {
}
// Create a Configmap containing the default jib profile.
-func CreateProfileConfigmap(ctx context.Context, c client.Client, kit
*v1.IntegrationKit) error {
- profile, err := jibMavenProfile()
+func CreateProfileConfigmap(ctx context.Context, c client.Client, catalog
*camel.RuntimeCatalog, kit *v1.IntegrationKit) error {
Review Comment:
In order to reduce the coupling, I'd instead create the profile externally
and pass it in this func instead of the catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
