davsclaus commented on code in PR #11715:
URL: https://github.com/apache/camel/pull/11715#discussion_r1357961755
##########
components/camel-micrometer/src/main/docs/micrometer-component.adoc:
##########
@@ -73,8 +73,12 @@ You should define a dedicated registry by providing
a `MeterRegistry` bean. Micrometer registries primarily determine the backend
monitoring system
to be used. A `CompositeMeterRegistry` can be used to address more than one
monitoring target.
-For example using Spring Java Configuration:
+For example using Java Configuration:
Review Comment:
The camel-spring-javaconfig has been removed and this example is not valid
anymore
##########
components/camel-micrometer/src/main/docs/micrometer-component.adoc:
##########
@@ -567,17 +575,33 @@ and add a `JmxMeterRegistry` instance:
HierarchicalNameMapper.DEFAULT));
return meterRegistry;
}
-}
----
-The `HierarchicalNameMapper` strategy determines how meter name and tags are
assembled into
-an MBean name.
+CDI::
++
+[source,java]
+----
+ @Produces
+ @Named(MicrometerConstants.METRICS_REGISTRY_NAME))
+ public MeterRegistry getMeterRegistry() {
+ CompositeMeterRegistry meterRegistry = new CompositeMeterRegistry();
+ meterRegistry.add(...);
+ meterRegistry.add(new JmxMeterRegistry(
+ CamelJmxConfig.DEFAULT,
+ Clock.SYSTEM,
+ HierarchicalNameMapper.DEFAULT));
+ return meterRegistry;
+ }
+----
+====
+
+The `HierarchicalNameMapper` strategy determines how meter name and tags are
assembled into an MBean name.
+ifeval::[{show-csb-content} == true]
Review Comment:
Can you remove this ifeval stuff, we do not use that at ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
