lburgazzoli commented on code in PR #4942:
URL: https://github.com/apache/camel-k/pull/4942#discussion_r1423850974
##########
pkg/apis/camel/v1/integration_types_support.go:
##########
@@ -25,8 +25,18 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
+// IntegrationLabel is used to tag k8s object created by a given Integration.
const IntegrationLabel = "camel.apache.org/integration"
+// IntegrationSyntheticLabel is used to tag k8s synthetic Integrations.
+const IntegrationSyntheticLabel = "camel.apache.org/is-synthetic"
+
+// IntegrationImportedKindLabel specifies from what kind of resource an
Integration was imported.
+const IntegrationImportedKindLabel = "camel.apache.org/imported-from-kind"
Review Comment:
> I thought that once the user imports an Integration, he wants to control
the lifecycle as well
I think it would become very complicated to do it right. In my opinion, the
synthetic integration is essentially a read only projection of the status of an
camel application so I won't go much further.
> The reconciliation deletion should still exists, when the user remove the
importing label because he wants the Deployment to no longer generates a
synthetic Integration.
true, but I guess if this should be something that falls in a GC algorithm
as I don't know if the way it is implemented as today, then it would work in
case of a restart of the operator as you may not receive a deletion event (but
have had a look at the code in depth so I may be wrong).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
