squakez commented on code in PR #5086:
URL: https://github.com/apache/camel-k/pull/5086#discussion_r1461509673
##########
pkg/trait/camel.go:
##########
@@ -276,5 +278,5 @@ func determineRuntimeVersion(e *Environment) string {
if e.Platform != nil && e.Platform.Status.Build.RuntimeVersion != "" {
return e.Platform.Status.Build.RuntimeVersion
}
- return ""
Review Comment:
I think this was on purpose. When there is no runtime set in any of the
status, it means something wrong happened. I think we need to keep the empty
value here to avoid unpredictable errors later. You can see the `Configure()`
func checking it and returning an error when this situation arises. Probably a
comment on top of the func would be good to avoid future misunderstanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
