squakez commented on code in PR #5126: URL: https://github.com/apache/camel-k/pull/5126#discussion_r1474843154
########## pkg/util/maven/maven_project_test.go: ########## @@ -181,6 +181,17 @@ func TestParseGAVMvnNoVersion(t *testing.T) { assert.Equal(t, dep.ArtifactID, "camel-core") } +func TestParseGAVMvnClassifierNoVersion(t *testing.T) { + dep, err := ParseGAV("org.apache.camel:camel-k-core:jar:custom") Review Comment: No, we're missing all the permutations, which are all the possible combinations with and without the fields: ``` <groupId>:<artifactId>:<packagingType>:<classifier>:<version> <groupId>:<artifactId>:<packagingType>:<classifier> <groupId>:<artifactId>:<packagingType>:<version> <groupId>:<artifactId>:<packagingType> <groupId>:<artifactId>:<classifier>:<version> <groupId>:<artifactId>:<classifier> <groupId>:<artifactId>:<version> <groupId>:<artifactId> ``` I did the math wrong, they are finally 8. As we're introducing more elements, we better have coverage of all possible scenarios. On the contrary we may be in the bad situation of looking for a bug in during a production workflow. I think it is worth the effort to test them all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org