mgubaidullin commented on PR #1113:
URL: https://github.com/apache/camel-karavan/pull/1113#issuecomment-1934354119

   Thank you @vidhyasagarj 
   
   a few comments
   
   backend
   1. We could keep a list of accepted components and kamelets in the files in 
the templates project.
   We store all global configuration there. No need for new caches, api, etc.
   
   frontend
   1. Data duplication in KameletApi and states in KnowledgebaseHome. We do not 
need to store same data in states because we could always call it from 
KameletApi. Data in KameletApi there should be updated when kamelets is blocked 
or unblocked
   
   vs-code extension
   1. Solution should be unified for web and vscode
   
   general
   1. remove additional formatting where no code changes
   2. When one user block and unblock component/kamelets how this impact other 
users (notified?)
   3. what if these kamelets/component already used in the projects? 
   4. Custom kamelets might be blocked or not?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to