lburgazzoli commented on code in PR #5281:
URL: https://github.com/apache/camel-k/pull/5281#discussion_r1537689066
##########
addons/strimzi/duck/v1beta2/duck_types.go:
##########
@@ -40,6 +40,12 @@ const (
type KafkaTopic struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
+ Spec KafkaTopicSpec `json:"spec,omitempty"`
+}
+
+// KafkaTopicSpec is the duck of a KafkaTopic spec.
+type KafkaTopicSpec struct {
Review Comment:
> I thought the same but I noticed the gen crd was tagged with `noStatus`
(tbh, not sure why), reason why I preferred to be conservative. I can
definitely move to the status if somebody confirm it would be the best thing to
do.
it seems this is for our own processing logic, maybe it is for the RBACs
generation. In the CRD definition I see that the staus is defined
https://github.com/strimzi/strimzi-kafka-operator/blob/main/install/cluster-operator/043-Crd-kafkatopic.yaml#L77-L110.
Maybe we should ask the Strimzi folks about what is the expected behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
