alexisgra opened a new pull request, #13707: URL: https://github.com/apache/camel/pull/13707
…emote websocket server # Description While trying to migrate from `camel-ahc-ws` to `camel-vertx-websocket`, I encountered a problem with the `consumeAsClient` option. The remote server I was trying to interact with refused to upgrade to websocket because of invalid query parameters. Previously, endpoint properties were set after configuring the `websocketURI`. As a result, when using the endpoint with `consumeAsClient` option, endpoint properties were passed as query param (`consumeAsClient` for example). Some APIs reject upgrade to websocket when unknown parameters are passed in the call. The purpose of this commit is to set endpoint properties before configuring `websocketURI`. So properties are binded and removed from the parameters map before configuring the `websocketURI`. This is inspired by the way `VertxHttpEndpoint` is instantiated. I modified the endpoint instanciation and I added a test to verify that endpoint properties are correctly removed from the `websocketURI` query params. # Target - [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch) # Tracking - [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). <!-- # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes. --> # Apache Camel coding standards and style - [x] I checked that each commit in the pull request has a meaningful subject line and body. <!-- If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue. --> - [x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes <!-- You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`. You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
