JiriOndrusek opened a new pull request, #5980: URL: https://github.com/apache/camel-quarkus/pull/5980
fixes https://github.com/apache/camel-quarkus/issues/5979 @ppalaga I thought, that the regenaration of keystores + some additional logic handling FIPS in tests would be needed (similar to https://github.com/quarkiverse/quarkus-cxf/pull/1297 and https://github.com/quarkiverse/quarkus-cxf/pull/1174). With the current simple fix the test suite works in FIPS environment. - There are no tests verifying that non-FIPS configuration fails -> which is the reason of not requiring special handling in the test, so it is OK - I'm not sure about the keystores though: 1. On one side - keystores can not be used "fully" to encrypt a message, because the proces should fail in FIPS 2. On the other side, it is not necessary to test such usecase, because it is covered by Quarkus-cxf, which is leveraged here. WDYT? a. Should we keep the fix this small? (I think so) b. Should we consider making the tests more covering (to use keystores properly)? (I'm not sure of it) <!-- Uncomment and fill this section if your PR is not trivial [ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes. [ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #. [ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough. [ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea. [ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request. [ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
